Skip to content

Conversation

@briandealwis
Copy link
Member

Maven's default checksumPolicy appears to be warn. This patch sets the checksum policy in our DependencyResolver to fail.

Unfortunately I can't figure out how to inject a RepositoryConnector or Transporter (or one of their providers or factories) to try to inject a transfer failure to test, but I did verify with a breakpoint that the checksum policy was set to error.

@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #2887 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2887      +/-   ##
============================================
+ Coverage     68.86%   68.92%   +0.06%     
- Complexity     2587     2591       +4     
============================================
  Files           353      353              
  Lines         12369    12371       +2     
  Branches       1468     1468              
============================================
+ Hits           8518     8527       +9     
+ Misses         3244     3241       -3     
+ Partials        607      603       -4
Impacted Files Coverage Δ Complexity Δ
...e/cloud/tools/eclipse/util/DependencyResolver.java 96.77% <100%> (+0.22%) 2 <0> (ø) ⬇️
...ow/ui/preferences/RunOptionsDefaultsComponent.java 77.81% <0%> (+1.45%) 44% <0%> (+3%) ⬆️
...ibraries/LibraryClasspathContainerResolverJob.java 100% <0%> (+25%) 4% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9718f00...2425046. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants