Setup CI by annguy3n · Pull Request #34 · GoogleCloudPlatform/java-bigtable-jdbc

annguy3n · 2026-02-11T21:55:40Z

Setup Continuous Integration via Kokoro

add more integration tests
fix date & timestamp parsing bug

gemini-code-assist · 2026-02-11T21:55:52Z

Summary of Changes

Hello @annguy3n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Kokoro build configuration for integration tests. The changes update the Maven command-line arguments to use a dedicated profile for integration tests and skip various build steps like checkstyle, unit tests, and formatting during this specific build phase. Additionally, a gcloud command was added to fetch the core project configuration, likely for debugging or environment setup.

Highlights

Kokoro Build Script Update: The Kokoro build script for integration tests has been modified to refine how these tests are executed.
Maven Integration Test Arguments: Maven command-line arguments for integration tests were updated, switching from a specific test class to an integration test profile and adjusting skipped build phases.
Gcloud Project Configuration: A gcloud command was added to retrieve the core project configuration during the integration test phase.

Changelog

.kokoro/build.sh
- Added comments to clarify the steps for running Application Default and Integration Tests.
- Included the gcloud config get-value core/project command.
- Replaced the -Dtest=BigtableDriverIT argument with -Penable-integration-tests to activate a Maven profile.
- Modified the list of skipped Maven phases/plugins, now skipping checkstyle, unit tests, and fmt instead of javadoc, gcloud download, and jacoco.

Activity

No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the integration test execution command in .kokoro/build.sh. The change to use a Maven profile (-Penable-integration-tests) is a good improvement for maintainability. However, it appears that properties for skipping plugins like JaCoCo and Javadoc were removed. I've added a comment suggesting to restore them to prevent longer build times or unexpected failures. It would also be beneficial to update the pull request title and description to be more descriptive of the changes.

.kokoro/build.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

brandtnewton · 2026-02-19T16:21:10Z

src/it/java/com/google/cloud/bigtable/jdbc/BigtableDriverSelectIT.java

+
+  private static final String PROJECT = getProperty("google.bigtable.project.id", "fakeProject");
+  private static final String INSTANCE = getProperty("google.bigtable.instance.id", "fakeInstance");
+  private static final String TABLE = getProperty("google.bigtable.table.id", "hotels");


how are the tables and views created/managed?

brandtnewton · 2026-02-19T16:23:03Z

src/it/java/com/google/cloud/bigtable/jdbc/BigtableDriverSelectIT.java

+  @Test
+  public void testBasicSelectStatement() throws Exception {
+    String url = String.format("jdbc:bigtable:/projects/%s/instances/%s", PROJECT, INSTANCE);
+    String select = String.format("SELECT * FROM `%s` WHERE hotel_info['id'] = ?", TABLE);


does the driver support literals? If so, it is worth adding some tests with literals in the where clause

brandtnewton · 2026-02-19T16:25:05Z

src/it/java/com/google/cloud/bigtable/jdbc/BigtableDriverSelectIT.java

+      assertTrue(connection.isValid(0));
+      PreparedStatement statement = connection.prepareStatement("Select 42;");
+       try (ResultSet rs = statement.executeQuery()) {
+        assertTrue(rs.next());


probably overkill but should we add an assertFalse(rs.next()) to make sure there are no more results here and in the other tests?

gemini-code-assist bot reviewed Feb 11, 2026

View reviewed changes

.kokoro/build.sh Show resolved Hide resolved

annguy3n added kokoro:run and removed kokoro:run labels Feb 13, 2026

yoshi-kokoro removed the kokoro:run label Feb 13, 2026

annguy3n added kokoro:run and removed kokoro:run labels Feb 17, 2026

yoshi-kokoro removed the kokoro:run label Feb 18, 2026

annguy3n force-pushed the beef-up-its branch from 4f21237 to 0451246 Compare February 19, 2026 04:10

Setup CI & add more tests

33fc29d

annguy3n force-pushed the beef-up-its branch from 0451246 to 33fc29d Compare February 19, 2026 04:14

Update .kokoro/build.sh

5524c5a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

annguy3n changed the title ~~draft~~ Setup CI Feb 19, 2026

update lint

abeec65

annguy3n marked this pull request as ready for review February 19, 2026 04:30

integration is already ran

55ff8d5

annguy3n requested review from brandtnewton, georgecma and mutianf and removed request for mutianf February 19, 2026 14:36

annguy3n requested review from brandtnewton, georgecma and mutianf and removed request for brandtnewton and georgecma February 19, 2026 15:33

mutianf approved these changes Feb 19, 2026

View reviewed changes

annguy3n merged commit 522400b into GoogleCloudPlatform:main Feb 19, 2026
11 checks passed

brandtnewton reviewed Feb 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Setup CI#34

Setup CI#34
annguy3n merged 4 commits intoGoogleCloudPlatform:mainfrom
annguy3n:beef-up-its

annguy3n commented Feb 11, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

brandtnewton Feb 19, 2026

Uh oh!

brandtnewton Feb 19, 2026

Uh oh!

brandtnewton Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

annguy3n commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

brandtnewton Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

brandtnewton Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

brandtnewton Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

annguy3n commented Feb 11, 2026 •

edited

Loading