feat: Add TPC support via universe_domain

[annguy3n]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @annguy3n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Bigtable JDBC driver by integrating support for 'universe_domain' configuration. This change enables users to connect to Bigtable instances residing in different cloud universes, specifically facilitating Third-Party Cloud (TPC) deployments. The core modification involves extending the client factory to accept and apply the 'universe_domain' property, ensuring flexible connectivity options for Bigtable clients.

Highlights

• TPC Support: Introduced support for Third-Party Cloud (TPC) connections by allowing the specification of a 'universe_domain' in Bigtable JDBC connection properties.
• Universe Domain Parameter: Added a 'universe_domain' parameter to the 'createBigtableDataClient' methods across the 'BigtableConnection', 'IBigtableClientFactory', and 'BigtableClientFactoryImpl' classes.
• Client Configuration: Modified 'BigtableClientFactoryImpl' to read the 'universe_domain' from connection properties and configure the 'BigtableDataSettings.Builder' accordingly.
• Test Coverage: Included a new test case in 'BigtableConnectionTest' to verify the correct handling and propagation of the 'universe_domain' property during client creation.

Changelog

• src/main/java/com/google/cloud/bigtable/jdbc/BigtableConnection.java
  • Added 'universe_domain' property retrieval from connection properties.
  • Updated the 'createBigtableDataClient' call to pass the new 'universe_domain'.
• src/main/java/com/google/cloud/bigtable/jdbc/client/BigtableClientFactoryImpl.java
  • Modified the 'createBigtableDataClient' method signature to accept 'universeDomain'.
  • Implemented logic to set the 'universeDomain' on the 'BigtableDataSettings.Builder' if provided.
• src/main/java/com/google/cloud/bigtable/jdbc/client/IBigtableClientFactory.java
  • Updated the 'createBigtableDataClient' interface method to include the 'universeDomain' parameter.
• src/test/java/com/google/cloud/bigtable/jdbc/BigtableConnectionTest.java
  • Added a new test 'testValidClientCreationWithUniverseDomain' to verify 'universe_domain' functionality.
  • Updated existing 'createBigtableDataClient' mock calls to include the new 'universe_domain' parameter (as null).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for specifying a universe_domain when creating a Bigtable connection, which is useful for TPC environments. The changes are well-implemented, propagating the new parameter through the connection factory and adding a test case for the new functionality. I've added a couple of suggestions to improve robustness by handling empty string values for universe_domain and to add a corresponding test case for this edge case.