Support direct controller for ReCAPTCHAEnterpriseFirewallPolicy #4172
Conversation
maqiuyujoyce
force-pushed
the
resource-recaptchaenterprise-firewallpolicy
branch
from
f017ef8 to
be1fef0
Compare
| log.V(2).Info("updating FirewallPolicy", "name", a.id) | ||
| mapCtx := &direct.MapContext{} | ||
|
|
||
| desiredPb := ReCAPTCHAEnterpriseFirewallPolicySpec_ToProto(mapCtx, &a.desired.Spec) |
There was a problem hiding this comment.
Can you double check if user can specify name in the Create call. If so, this logic need to be updated to support custom id
There was a problem hiding this comment.
The resource has service-generated ID so the name shouldn't be set during Create. Even if it is set, the value won't be respected by the API.
yuwenma
left a comment
yuwenma
left a comment
There was a problem hiding this comment.
/approve
One question to confirm, otherwise looks good
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maqiuyujoyce
force-pushed
the
resource-recaptchaenterprise-firewallpolicy
branch
from
5699bd0 to
841af85
Compare
|
/lgtm |
google-oss-prow
bot
merged commit e5c9d3f
into
GoogleCloudPlatform:master
4 participants
Change description
ReCAPTCHAEnterpriseFirewallPolicy is supported based on the GRPC client.
Tests you have done
make ready-prto ensure this PR is ready for review.These is no commit for test result against mock API because there is no diff to commit.