Skip to content

fix missing alias for name secret_ref (hashicorp#21272)#12982

Merged
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
aprochko:cloudrun-service-docs-update_issue-21272
Feb 10, 2025
Merged

fix missing alias for name secret_ref (hashicorp#21272)#12982
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
aprochko:cloudrun-service-docs-update_issue-21272

Conversation

@aprochko
Copy link
Copy Markdown
Contributor

@aprochko aprochko commented Feb 6, 2025

fix missing alias for name secret_ref (hashicorp#21272)

fixes hashicorp/terraform-provider-google#21272

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrun - fix missing alias for name secret_ref (hashicorp#21272)

@google-cla
Copy link
Copy Markdown

google-cla bot commented Feb 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from trodge February 6, 2025 12:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 6, 2025
@modular-magician modular-magician added service/run and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 7, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 32
Passed tests: 26
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • cloudrun

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: Alias form of secret name in google_cloud_run_service is not correct

3 participants