Skip to content

Fix instances where no items found in region by continuing to next region#13027

Merged
ScottSuarez merged 6 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:fix-region-sweepers
Feb 10, 2025
Merged

Fix instances where no items found in region by continuing to next region#13027
ScottSuarez merged 6 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:fix-region-sweepers

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

@ScottSuarez ScottSuarez commented Feb 10, 2025

also including a rename of SweepableIdentifierField to identifier_field

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@ScottSuarez ScottSuarez requested a review from melinath February 10, 2025 20:15
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 227 files changed, 227 insertions(+), 379 deletions(-))
google-beta provider: Diff ( 270 files changed, 270 insertions(+), 422 deletions(-))

- 'transport_tpg.IsMonitoringPermissionError'
schema_version: 1
state_upgraders: true
exclude_sweeper: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this excluded?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done at the organization level and not the project level.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting! Another potential case that would be fixed by moving to more complex list URL handling.

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3177
Passed tests: 2918
Skipped tests: 255
Affected tests: 4

Click here to see the affected service packages
  • pubsublite
  • securitycenter
  • datacatalog
  • dialogflowcx
  • managedkafka
  • migrationcenter
  • notebooks
  • securitycenterv2
  • workbench
  • eventarc
  • firebaseappcheck
  • biglake
  • cloudasset
  • discoveryengine
  • edgenetwork
  • integrationconnectors
  • parallelstore
  • apigee
  • beyondcorp
  • dataprocgdc
  • secretmanager
  • transcoder
  • activedirectory
  • appengine
  • dataplex
  • gkeonprem
  • identityplatform
  • networkconnectivity
  • securityscanner
  • cloudbuildv2
  • containeranalysis
  • dataprocmetastore
  • documentai
  • gkebackup
  • privateca
  • apphub
  • bigqueryanalyticshub
  • cloudtasks
  • colab
  • databasemigrationservice
  • dataproc
  • datastream
  • iamworkforcepool
  • apigateway
  • bigqueryconnection
  • workstations
  • iap
  • tpuv2
  • sql
  • vmwareengine
  • corebilling
  • memcache
  • logging
  • vertexai
  • cloudscheduler
  • deploymentmanager
  • iambeta
  • memorystore
  • networkmanagement
  • storageinsights
  • gemini
  • gkehub2
  • backupdr
  • bigquerydatapolicy
  • blockchainnodeengine
  • clouddeploy
  • cloudrun
  • compute
  • alloydb
  • artifactregistry
  • firebaseextensions
  • networksecurity
  • pubsub
  • securitycentermanagement
  • dataform
  • edgecontainer
  • networkservices
  • tpu
  • datafusion
  • developerconnect
  • monitoring
  • tags
  • firebasestorage
  • integrations
  • cloudbuild
  • datapipeline
  • filestore
  • secretmanagerregional
  • siteverification
  • vpcaccess
  • bigqueryreservation
  • certificatemanager
  • osconfig
  • parametermanager
  • sourcerepo
  • storagetransfer
  • billing
  • cloudfunctions2
  • parametermanagerregional
  • redis
  • firebasehosting
  • mlengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccCloudbuildWorkerPool_basic
  • TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Feb 12, 2025
…gion (GoogleCloudPlatform#13027)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
…gion (GoogleCloudPlatform#13027)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
…gion (GoogleCloudPlatform#13027)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
…gion (GoogleCloudPlatform#13027)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants