Added new profile type "URL_FILTERING" for SecurityProfile #13342

matheusaleixo-cit · 2025-03-12T18:22:49Z

Adds the option to manage a new profile type URL_FILTERING for networksecurity SecurityProfile and SecurityProfileGroup, adding the url_filtering_profile field and related tests to those resources.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networksecurity: added `URL_FILTERING` option to enum field `type` for `google_network_security_security_profile` resource

networksecurity: added `url_filtering_profile` field  to `google_network_security_security_profile` resource (beta)

networksecurity: added `url_filtering_profile` field  to `google_network_security_security_profile_group` resource (beta)

… for SecurityProfile; - Added urlFilteringProfile field to SecurityProfileGroup;

- Added default url_filters to SecurityProfile and SecurityProfileGroup tests;

…urity-security-profile

github-actions · 2025-09-17T20:04:15Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

slevenick · 2025-09-17T20:40:06Z

mmv1/products/networksecurity/SecurityProfile.yaml

+      - 'urlFilteringProfile'
+      - 'customMirroringProfile'
+      - 'customInterceptProfile'
+  - name: 'urlFilteringProfile'


Can you add an update test for this field? Adding/deleting items in the url_filters set is the main thing to test

modular-magician · 2025-09-18T17:20:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 109 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 9 files changed, 644 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 336 insertions(+), 5 deletions(-))

modular-magician · 2025-09-18T17:25:28Z

Tests analytics

Total tests: 70
Passed tests: 63
Skipped tests: 4
Affected tests: 3

Click here to see the affected service packages

networksecurity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupUrlFilteringExample

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringExample

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate

Get to know how VCR tests work

modular-magician · 2025-09-18T17:25:42Z

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupUrlFilteringExample [Error message] [Debug log]
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringExample [Error message] [Debug log]
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

slevenick

Beta-only tests need provider = google-beta declared in the config

modular-magician · 2025-09-18T21:27:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 112 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 9 files changed, 655 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 336 insertions(+), 5 deletions(-))

modular-magician · 2025-09-18T21:31:41Z

Tests analytics

Total tests: 70
Passed tests: 63
Skipped tests: 4
Affected tests: 3

Click here to see the affected service packages

networksecurity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupUrlFilteringExample

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringExample

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate

Get to know how VCR tests work

modular-magician · 2025-09-18T21:33:04Z

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupUrlFilteringExample [Debug log]
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…ority 2147483647 cannot be updated); - Changed update test step 2 to now update rule priority 1;

github-actions · 2025-09-23T09:43:48Z

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-09-23T15:47:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 112 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 9 files changed, 622 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 336 insertions(+), 5 deletions(-))

modular-magician · 2025-09-23T15:51:28Z

Tests analytics

Total tests: 70
Passed tests: 65
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate

Get to know how VCR tests work

modular-magician · 2025-09-23T15:52:08Z

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

matheusaleixo-cit · 2025-09-24T16:52:41Z

I'm having problems running the tests for this resource locally (facing some ADC auth problems when creating organization level resources), can you show me the logs for the failing update test?
I imagine the default url_filter (priority 2147483647) would be causing issues.

github-actions · 2025-09-25T09:43:54Z

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

slevenick

Yeah it looks like the default rule is causing issues:
It fails with resource_network_security_security_profile_test.go:121: Step 1/8 error: After applying this test step, the plan was not empty.

              - url_filters {
                  - filtering_action = "DENY" -> null
                  - priority         = 2147483647 -> null
                  - urls             = [
                      - "*",
                    ] -> null
                }
            }
        }

Looks like it's getting a default profile set automatically

… auto-created url_filter; - Removed from example tests the url_filter using default priority (2147483647) as these are currently immutable;

modular-magician · 2025-10-02T16:44:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 102 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 9 files changed, 632 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 365 insertions(+), 5 deletions(-))

modular-magician · 2025-10-02T16:48:23Z

Tests analytics

Total tests: 71
Passed tests: 64
Skipped tests: 4
Affected tests: 3

Click here to see the affected service packages

networksecurity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupUrlFilteringExample

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringExample

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate

Get to know how VCR tests work

modular-magician · 2025-10-02T16:50:07Z

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupUrlFilteringExample [Debug log]
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

slevenick · 2025-10-02T17:16:13Z

...lates/terraform/custom_flatten/network_security_security_profile_url_filters_flatten.go.tmpl

+
+		priorityFlatten := flattenNetworkSecuritySecurityProfileUrlFilteringProfileUrlFiltersPriority(original["priority"], d, config)
+		// Do not include the auto created default url_filter coming back from the api unless the user included it in his config
+		if priorityFlatten == 2147483647 && !resourceDataContainsDefaultFilter {


I think this is causing the failure, the default priority is included in the config but we aren't seeing it in state after import:
=== CONT TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate
resource_network_security_security_profile_test.go:121: Step 8/10 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.

map[string]string{ - "url_filtering_profile.#": "1", - "url_filtering_profile.0.%": "1", }

Or the place above where we check for this priority specifically

…ering_profile field instead of only url_filters;

modular-magician · 2025-10-02T18:22:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 102 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 9 files changed, 632 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 365 insertions(+), 5 deletions(-))

modular-magician · 2025-10-02T18:25:53Z

Tests analytics

Total tests: 71
Passed tests: 66
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate

Get to know how VCR tests work

modular-magician · 2025-10-02T18:28:09Z

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileUrlFilteringUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…udPlatform#13342)

matheusaleixo-cit added 3 commits March 7, 2025 18:42

- Added new profile type URL_FILTERING and urlFilteringProfile config…

16d6860

… for SecurityProfile; - Added urlFilteringProfile field to SecurityProfileGroup;

- Renamed SecurityProfileGroup url_monitoring test example;

9ef5430

- Added default url_filters to SecurityProfile and SecurityProfileGroup tests;

- URL Filtering Profile fields and test examples are now beta only;

7d37ed7

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 12, 2025

matheusaleixo-cit added 2 commits September 15, 2025 11:35

Merge branch 'main' into add-new-url-filtering-feature-for-networksec…

4d20455

…urity-security-profile

Merge branch 'main' into add-new-url-filtering-feature-for-networksec…

1b09dd8

…urity-security-profile

matheusaleixo-cit marked this pull request as ready for review September 17, 2025 20:03

github-actions bot requested a review from slevenick September 17, 2025 20:04

slevenick reviewed Sep 17, 2025

View reviewed changes

- Added update tests for url_filtering_profile;

ad8bafa

github-actions bot requested a review from slevenick September 17, 2025 23:04

modular-magician added service/network-security-distributed-firewall and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 18, 2025

slevenick requested changes Sep 18, 2025

View reviewed changes

- Fixed example and update tests not using beta providers;

3d22221

github-actions bot requested a review from slevenick September 18, 2025 20:19

- Removed update test step 4 from urlFltering test (due to filter pri…

ed46dd3

…ority 2147483647 cannot be updated); - Changed update test step 2 to now update rule priority 1;

slevenick reviewed Sep 26, 2025

View reviewed changes

- Added urlFilteringProfile custom_flatten code to handle the default…

40fb33b

… auto-created url_filter; - Removed from example tests the url_filter using default priority (2147483647) as these are currently immutable;

github-actions bot requested a review from slevenick October 2, 2025 00:06

- Fixed mistype in ImportStateVerifyIgnore;

3e2a441

slevenick requested changes Oct 2, 2025

View reviewed changes

- Changed test ImportStateVerifyIgnore to include the entire url_filt…

5d93cfd

…ering_profile field instead of only url_filters;

github-actions bot requested a review from slevenick October 2, 2025 17:48

slevenick approved these changes Oct 3, 2025

View reviewed changes

slevenick added this pull request to the merge queue Oct 3, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 5714840 Oct 3, 2025
27 checks passed

jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025

Added new profile type "URL_FILTERING" for SecurityProfile (GoogleClo…

c0e2b3d

…udPlatform#13342)

matheusaleixo-cit deleted the add-new-url-filtering-feature-for-networksecurity-security-profile branch October 15, 2025 13:57

g-dreva pushed a commit to g-dreva/magic-modules that referenced this pull request Oct 15, 2025

Added new profile type "URL_FILTERING" for SecurityProfile (GoogleClo…

c0800f2

…udPlatform#13342)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 20, 2025

Added new profile type "URL_FILTERING" for SecurityProfile (GoogleClo…

fe95c29

…udPlatform#13342)

SirGitsalot pushed a commit that referenced this pull request Oct 30, 2025

Added new profile type "URL_FILTERING" for SecurityProfile (#13342)

9a9a042

Added new profile type "URL_FILTERING" for SecurityProfile #13342

Added new profile type "URL_FILTERING" for SecurityProfile #13342

Uh oh!

Conversation

matheusaleixo-cit commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

slevenick Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Sep 18, 2025

Diff report

Uh oh!

modular-magician commented Sep 18, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 18, 2025

Uh oh!

slevenick left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Sep 18, 2025

Diff report

Uh oh!

modular-magician commented Sep 18, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

modular-magician commented Sep 23, 2025

Diff report

Uh oh!

modular-magician commented Sep 23, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 23, 2025

Uh oh!

matheusaleixo-cit commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

slevenick left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Oct 2, 2025

Diff report

Uh oh!

modular-magician commented Oct 2, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Oct 2, 2025

Uh oh!

slevenick Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

slevenick Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Oct 2, 2025

Diff report

Uh oh!

modular-magician commented Oct 2, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

matheusaleixo-cit commented Mar 12, 2025 •

edited

Loading