HTTP transport functions for fwprovider by NickElliot · Pull Request #13496 · GoogleCloudPlatform/magic-modules

NickElliot · 2025-03-31T23:04:54Z

SendRequest() is largely the same as in transport_tpg, but is updated for "diags" error handling

getProjectFromFrameworkSchema() is updated to a more generalized getProviderDefaultFromFrameworkSchema(), the original function as implemented by Sarah is largely accommodating of this change, "project" as a string being something it needed supplied as an arg rather than being inbuilt to the function

ReplaceVarsRecursive() and related functions have been rewritten to work with the [crud]Request types from plugin framework, relying on interface (type) checking to access the correct values when needed

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

modular-magician · 2025-03-31T23:16:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 438 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 439 insertions(+), 3 deletions(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2025-03-31T23:19:52Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

NickElliot · 2025-04-03T21:46:55Z

/gcbrun

modular-magician · 2025-04-03T21:57:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 588 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 589 insertions(+), 4 deletions(-))

modular-magician · 2025-04-03T23:59:19Z

Tests analytics

Total tests: 4783
Passed tests: 4337
Skipped tests: 439
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-04T00:13:32Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-04T20:13:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 489 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 490 insertions(+), 4 deletions(-))

modular-magician · 2025-04-04T20:15:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 489 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 490 insertions(+), 4 deletions(-))

c2thorn

seems good on initial pass. Want to add some simple datasource style tests for the data source?

c2thorn · 2025-04-04T20:25:42Z

        resourcemanager.NewGoogleClientConfigDataSource,
        resourcemanager.NewGoogleClientOpenIDUserinfoDataSource,
        {{- if ne $.TargetVersionName "ga" }}
+        resourcemanager.NewGoogleProjectFWDataSource,


let's move the datasource to test-only for now, like in https://github.com/GoogleCloudPlatform/magic-modules/pull/12741/files#diff-7c30a2afcc18eb3bf49388e586c1bcb0f84fcb5768c5a9366d4d34f0dd9dd548

c2thorn · 2025-04-04T20:30:34Z

+
+// Metadata returns the data source type name.
+func (d *GoogleProjectFWDataSource) Metadata(_ context.Context, req datasource.MetadataRequest, resp *datasource.MetadataResponse) {
+	resp.TypeName = req.ProviderTypeName + "_fwprovider_project"


shall we shorten to something like _fw_project or project_fw? We should probably standardize to something for now. Sarah had https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/fwprovider/data_source_provider_config_plugin_framework.go#L58, but that feels different enough

modular-magician · 2025-04-04T21:01:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 329 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 329 insertions(+), 4 deletions(-))

modular-magician · 2025-04-04T22:13:07Z

Tests analytics

Total tests: 4783
Passed tests: 4338
Skipped tests: 439
Affected tests: 6

Click here to see the affected service packages

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-04T22:17:36Z

Tests analytics

Total tests: 4783
Passed tests: 4337
Skipped tests: 439
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-04T22:29:55Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-04T22:31:45Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-04T23:04:02Z

Tests analytics

Total tests: 4785
Passed tests: 4340
Skipped tests: 441
Affected tests: 4

Click here to see the affected service packages

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-04T23:14:59Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

NickElliot · 2025-04-07T16:15:37Z

/gcbrun

NickElliot · 2025-04-07T17:04:21Z

/gcbrun

modular-magician · 2025-04-07T17:15:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 329 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 329 insertions(+), 4 deletions(-))

modular-magician · 2025-04-07T19:15:23Z

Tests analytics

Total tests: 4788
Passed tests: 4337
Skipped tests: 446
Affected tests: 5

Click here to see the affected service packages

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-07T19:33:58Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

c2thorn

failing tests already fail in nightlies

NickElliot marked this pull request as draft March 31, 2025 23:05

NickElliot changed the base branch from main to fwprovider-feature-test April 2, 2025 20:05

NickElliot force-pushed the httpfwprovider branch 2 times, most recently from 5346f4d to cadaeb6 Compare April 3, 2025 21:30

NickElliot added 6 commits April 3, 2025 14:38

demo data source

570f191

initial

8cd40b8

cleanup + transport functions

f4e201b

build issue

52847d7

build issue

0c0637a

full build

e431331

NickElliot force-pushed the httpfwprovider branch from cadaeb6 to e431331 Compare April 3, 2025 21:39

NickElliot changed the base branch from fwprovider-test to main April 3, 2025 21:42

NickElliot requested a review from c2thorn April 4, 2025 18:21

NickElliot marked this pull request as ready for review April 4, 2025 18:21

NickElliot added 2 commits April 4, 2025 13:01

refactor type switches

8871500

gofmt

590bfd2

c2thorn requested changes Apr 4, 2025

View reviewed changes

remove data source in seperate PR

ab52a7a

c2thorn approved these changes Apr 7, 2025

View reviewed changes

NickElliot changed the base branch from main to fwprovider-test April 7, 2025 16:15

NickElliot changed the base branch from fwprovider-test to FEATURE-BRANCH-plugin-framework April 7, 2025 17:01

c2thorn self-requested a review April 7, 2025 17:12

c2thorn approved these changes Apr 8, 2025

View reviewed changes

NickElliot merged commit 35cebed into GoogleCloudPlatform:FEATURE-BRANCH-plugin-framework Apr 8, 2025

Conversation

NickElliot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Mar 31, 2025

Diff report

Errors

Uh oh!

modular-magician commented Mar 31, 2025

Tests analytics

Uh oh!

NickElliot commented Apr 3, 2025

Uh oh!

modular-magician commented Apr 3, 2025

Diff report

Uh oh!

modular-magician commented Apr 3, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2025

Uh oh!

modular-magician commented Apr 4, 2025

Diff report

Uh oh!

modular-magician commented Apr 4, 2025

Diff report

Uh oh!

c2thorn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c2thorn Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

c2thorn Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Apr 4, 2025

Diff report

Uh oh!

modular-magician commented Apr 4, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2025

Uh oh!

modular-magician commented Apr 4, 2025

Uh oh!

modular-magician commented Apr 4, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2025

Uh oh!

NickElliot commented Apr 7, 2025

Uh oh!

NickElliot commented Apr 7, 2025

Uh oh!

modular-magician commented Apr 7, 2025

Diff report

Uh oh!

modular-magician commented Apr 7, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 7, 2025

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

NickElliot commented Mar 31, 2025 •

edited

Loading

c2thorn left a comment •

edited

Loading