Removed cloud identity group membership set_computed_name post_create

[melinath]

This is now duplicate code. Part of hashicorp/terraform-provider-google#22214

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[melinath]

I'm not able to get this test to pass in CI for unrelated reasons; however, visual examination of the generated code shows that the ID is already being set based on the name field. This test does pass in nightlies so I can do a manual run once the change propagates to downstreams.

@modular-magician reassign-reviewer

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 deletions(-))
google-beta provider: Diff ( 1 file changed, 18 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• cloudidentity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudIdentityGroup

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityGroup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

Post-merge manual test: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS_GOOGLEBETA_PACKAGE_CLOUDIDENTITY/378882