Combine all post replay templates into one#13958
Combine all post replay templates into one#13958trodge merged 6 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
@modular-magician reassign-reviewer |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
melinath
left a comment
There was a problem hiding this comment.
a couple small things. could you also make a change to a resource on this PR to exercise the new template? (Or make a global change to trigger a full test run.) here are some always-failing tests: #13836 (comment)
.ci/magician/cmd/test_eap_vcr.go
Outdated
| } | ||
|
|
||
| withReplayFailedTestsComment, err := formatWithReplayFailedTests(withReplayFailedTestsData) | ||
| comment, err := formatPostReplay(postReplayData) |
There was a problem hiding this comment.
Formatting & posting the comment can happen before this if statement, since it's now the same render + post either way.
| ReplayingResult: replayingResult, | ||
| } | ||
| withReplayFailedTestsComment, err := formatWithReplayFailedTests(withReplayFailedTestsData) | ||
| comment, err := formatPostReplay(postReplayData) |
Tests analyticsTotal tests: 3 Click here to see the affected service packages
View the build log |
This reverts commit 520400e.
Tests analyticsTotal tests: 4962 Click here to see the affected service packages
Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
This reverts commit bd0dcf7.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
534cbed
fixes hashicorp/terraform-provider-google#19675
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.