Skip to content

Conversation

@raazanand
Copy link
Contributor

@raazanand raazanand commented May 23, 2025

netapp: added `backup_retention_policy.backup_minimum_enforced_retention_days`, `backup_retention_policy.daily_backup_immutable`, `backup_retention_policy.weekly_backup_immutable`, `backup_retention_policy.monthly_backup_immutable`, and `backup_retention_policy.manual_backup_immutable` fields to `google_netapp_backup_vault`

This change adds a comprehensive integration test for NetApp Immutable Backups. The test covers the following scenarios:

  • Creation of resources: Storage Pool, Volume, Backup Vault, Volume Snapshot, and Backup.
  • Validation of Immutable Backup creation and its properties.
  • Import state verification for the backup resource.

The test leverages the acctest framework and includes a time_sleep resource to allow for storage pool creation.

@github-actions github-actions bot requested a review from melinath May 23, 2025 11:57
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@raazanand raazanand marked this pull request as draft May 23, 2025 12:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 301 insertions(+))
google-beta provider: Diff ( 4 files changed, 301 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 301 insertions(+))
google-beta provider: Diff ( 4 files changed, 301 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 301 insertions(+))
google-beta provider: Diff ( 4 files changed, 301 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 365 insertions(+))
google-beta provider: Diff ( 4 files changed, 365 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 377 insertions(+))
google-beta provider: Diff ( 4 files changed, 377 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 301 insertions(+))
google-beta provider: Diff ( 4 files changed, 301 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 27
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
🟢 All tests passed!

View the build log

@raazanand raazanand marked this pull request as ready for review May 24, 2025 07:03
@raazanand raazanand marked this pull request as draft May 24, 2025 07:21
@github-actions github-actions bot requested a review from melinath May 29, 2025 20:43
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 377 insertions(+))
google-beta provider: Diff ( 4 files changed, 377 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, at least one of them needs to be true if this block is set at all.

@github-actions github-actions bot requested a review from melinath May 29, 2025 22:16
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 377 insertions(+))
google-beta provider: Diff ( 4 files changed, 377 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 73 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackup_NetappImmutableBackup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappBackup_NetappImmutableBackup [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@melinath melinath added this pull request to the merge queue May 29, 2025
Merged via the queue into GoogleCloudPlatform:main with commit c3228e5 May 30, 2025
28 checks passed
@raazanand raazanand deleted the immutableBackups branch May 30, 2025 03:15
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
sahil-mahajan-google pushed a commit to sahil-mahajan-google/magic-modules that referenced this pull request Jun 6, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants