Skip to content

Add Curation resource of API hub#14174

Merged
hao-nan-li merged 5 commits intoGoogleCloudPlatform:mainfrom
balanaguharsha:main
Jun 3, 2025
Merged

Add Curation resource of API hub#14174
hao-nan-li merged 5 commits intoGoogleCloudPlatform:mainfrom
balanaguharsha:main

Conversation

@balanaguharsha
Copy link
Copy Markdown
Contributor

@balanaguharsha balanaguharsha commented Jun 2, 2025

Adding support for Curation resource of API hub.

Release Note Template for Downstream PRs (will be copied)

`google_apihub_curation`

Local run: https://paste.googleplex.com/4723518274797568

Fixes: hashicorp/terraform-provider-google#23127

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1356 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1356 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • apihub
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApihubCuration_apihubCurationBasicExample
  • TestAccApihubCuration_apihubCurationBasic_Update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApihubCuration_apihubCurationBasicExample [Error message] [Debug log]
TestAccApihubCuration_apihubCurationBasic_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1356 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1356 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • apihub
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApihubCuration_apihubCurationBasicExample
  • TestAccApihubCuration_apihubCurationBasic_Update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApihubCuration_apihubCurationBasicExample [Error message] [Debug log]
TestAccApihubCuration_apihubCurationBasic_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@balanaguharsha balanaguharsha force-pushed the main branch 2 times, most recently from 08c0fea to 52b2a62 Compare June 2, 2025 14:31
Comment thread .ci/infra/terraform/main.tf Outdated
@hao-nan-li
Copy link
Copy Markdown
Contributor

/gcbrun

@github-actions github-actions Bot requested a review from hao-nan-li June 2, 2025 17:47
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1356 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1356 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • apihub
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApihubCuration_apihubCurationBasicExample
  • TestAccApihubCuration_apihubCurationBasic_Update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApihubCuration_apihubCurationBasicExample [Error message] [Debug log]
TestAccApihubCuration_apihubCurationBasic_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1358 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1358 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • apihub
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApihubCuration_apihubCurationBasicExample
  • TestAccApihubCuration_apihubCurationBasic_Update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApihubCuration_apihubCurationBasicExample [Error message] [Debug log]
TestAccApihubCuration_apihubCurationBasic_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1358 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1358 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • apihub
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApihubCuration_apihubCurationBasicExample
  • TestAccApihubCuration_apihubCurationBasic_Update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApihubCuration_apihubCurationBasicExample [Error message] [Debug log]
TestAccApihubCuration_apihubCurationBasic_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Comment thread mmv1/products/apihub/Curation.yaml
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1234 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1234 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApihubCuration_apihubCurationBasic_Update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • apihub
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1236 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1236 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1236 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1236 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApihubCuration_apihubCurationBasic_Update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • apihub
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApihubCuration_apihubCurationBasic_Update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • apihub
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1235 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1235 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApihubCuration_apihubCurationBasic_Update

Tests analytics

Total tests: 2
Passed tests: 1
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • apihub
🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li added this pull request to the merge queue Jun 3, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 72741e5 Jun 3, 2025
27 checks passed
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
sahil-mahajan-google pushed a commit to sahil-mahajan-google/magic-modules that referenced this pull request Jun 6, 2025
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request Jun 18, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Curation resource of API hub

3 participants