-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Terraform integration for adding output only RoleBinding ID to entitlement resource #14218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform integration for adding output only RoleBinding ID to entitlement resource #14218
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
View the build log |
0185be9 to
fc4fb08
Compare
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| description: | | ||
| The expression field of the IAM condition to be associated with the role. If specified, a user with an active grant for this entitlement would be able to access the resource only if this condition evaluates to true for their request. | ||
| https://cloud.google.com/iam/docs/conditions-overview#attributes. | ||
| - name: 'id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test or extend an existing test where we check the presence of this output field? Should likely be a handwritten test.
fc4fb08 to
69a758e
Compare
69a758e to
3bc51b2
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
f3d2390
This Pull Request enhances the Entitlement Terraform resource by introducing a new RoleBinding id field. This is an OUTPUT ONLY field, meaning it will display the id for each of the role bindings associated with the entitlement, providing more visibility into the assigned roles and enabling more granular scoped grant creation.
Important Note: This Pull Request is being submitted for early review and feedback. However, it should only be merged into the main codebase once the backend API supporting scope selection has been fully promoted to beta. This dependency ensures that the new id field functions correctly and as intended with the corresponding API changes.