Skip to content

Conversation

@ankitprsad99
Copy link
Contributor

@ankitprsad99 ankitprsad99 commented Jun 8, 2025

This Pull Request enhances the Entitlement Terraform resource by introducing a new RoleBinding id field. This is an OUTPUT ONLY field, meaning it will display the id for each of the role bindings associated with the entitlement, providing more visibility into the assigned roles and enabling more granular scoped grant creation.

Important Note: This Pull Request is being submitted for early review and feedback. However, it should only be merged into the main codebase once the backend API supporting scope selection has been fully promoted to beta. This dependency ensures that the new id field functions correctly and as intended with the corresponding API changes.

privilegedaccessmanager: added  RoleBinding `id` field to `google_privileged_access_manager_entitlement` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 3 files changed, 26 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • privilegedaccessmanager
🟢 All tests passed!

View the build log

@ankitprsad99 ankitprsad99 force-pushed the add-entitlement-roleBindingId branch from 0185be9 to fc4fb08 Compare September 17, 2025 06:52
@ankitprsad99 ankitprsad99 marked this pull request as ready for review September 17, 2025 06:59
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

description: |
The expression field of the IAM condition to be associated with the role. If specified, a user with an active grant for this entitlement would be able to access the resource only if this condition evaluates to true for their request.
https://cloud.google.com/iam/docs/conditions-overview#attributes.
- name: 'id'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test or extend an existing test where we check the presence of this output field? Should likely be a handwritten test.

@ankitprsad99 ankitprsad99 force-pushed the add-entitlement-roleBindingId branch from fc4fb08 to 69a758e Compare September 18, 2025 09:40
@ankitprsad99 ankitprsad99 force-pushed the add-entitlement-roleBindingId branch from 69a758e to 3bc51b2 Compare September 18, 2025 13:20
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 5 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 98 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 2
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • privilegedaccessmanager

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject
  • TestAccPrivilegedAccessManagerEntitlement_roleBindingId_beta

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic [Debug log]
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject [Debug log]
TestAccPrivilegedAccessManagerEntitlement_roleBindingId_beta [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@ScottSuarez ScottSuarez added this pull request to the merge queue Sep 18, 2025
Merged via the queue into GoogleCloudPlatform:main with commit f3d2390 Sep 18, 2025
27 checks passed
sahil-mahajan-google pushed a commit to sahil-mahajan-google/magic-modules that referenced this pull request Sep 19, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Sep 26, 2025
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants