Update service account creation to be more resilient to eventual cons…

[chasevedder]

This changes service account creation to no longer require a final GetServiceAccount request to succeed. Instead, we will wait until we get 3 consecutive successful responses from GetServiceAccount before considering the create successful.

closes hashicorp/terraform-provider-google#22546

resourcemanager: updated service account creation to prevent failures due to eventual consistency in `google_service_account` resource 

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 36 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 1 file changed, 36 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 163
Passed tests: 132
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccServiceAccount_createIgnoreAlreadyExists

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 36 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 1 file changed, 36 insertions(+), 27 deletions(-))

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccServiceAccount_createIgnoreAlreadyExists [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 165
Passed tests: 134
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccServiceAccount_createIgnoreAlreadyExists

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccServiceAccount_createIgnoreAlreadyExists [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[trodge]

I think we still want to set id in this case. We only want to avoid setting id if creation fails (i.e. we got a non-409 error or create_ignore_already_exists is false.

[chasevedder]

Updated

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 38 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 1 file changed, 38 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 163
Passed tests: 133
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

🟢 All tests passed!

View the build log