Switched to API field name as primary metadata

[melinath]

This allows us to preserve the exact API field name in metadata while still being able to programmatically derive the terraform field name. Since conversion to terraform name is lossy, we can't reliably go the other direction.

This PR only handles generated meta.yaml files. If this approach works, I'll handle the handwritten files separately later.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 643 files changed, 13979 insertions(+), 13979 deletions(-))
google-beta provider: Diff ( 696 files changed, 14905 insertions(+), 14905 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 643 files changed, 14011 insertions(+), 14011 deletions(-))
google-beta provider: Diff ( 696 files changed, 14937 insertions(+), 14937 deletions(-))

[roaks3]

I think we may want to update docs/content/reference/metadata.md, at least slightly. api_field will now be camelcased, and I assume field will default to the snakecased version of api_field?

Also:

Since conversion to terraform name is lossy, we can't reliably go the other direction

Could you clarify, or possibly have an example to share?

Everything else LGTM (including a scan of the results)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 654 files changed, 14391 insertions(+), 14391 deletions(-))
google-beta provider: Diff ( 711 files changed, 15396 insertions(+), 15396 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 654 files changed, 14391 insertions(+), 14391 deletions(-))
google-beta provider: Diff ( 711 files changed, 15396 insertions(+), 15396 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 658 files changed, 14465 insertions(+), 14465 deletions(-))
google-beta provider: Diff ( 718 files changed, 15515 insertions(+), 15515 deletions(-))

[melinath]

I think we may want to update docs/content/reference/metadata.md, at least slightly. api_field will now be camelcased, and I assume field will default to the snakecased version of api_field?

Done. Yes, those are the changes.

Since conversion to terraform name is lossy, we can't reliably go the other direction

Could you clarify, or possibly have an example to share?

Conversion to terraform name uses this function:

magic-modules/mmv1/google/string_utils.go

Lines 27 to 34 in 4e1621c

	func Underscore(source string) string {
	tmp := regexp.MustCompile(`([A-Z]+)([A-Z][a-z])`).ReplaceAllString(source, "${1}_${2}")
	tmp = regexp.MustCompile(`([a-z\d])([A-Z])`).ReplaceAllString(tmp, "${1}_${2}")
	tmp = strings.Replace(tmp, "-", "_", 1)
	tmp = strings.Replace(tmp, ".", "_", 1)
	tmp = strings.ToLower(tmp)
	return tmp
	}

It looks like we don't have any fields that contain . or - in their API names, so the fact those get collapsed doesn't matter (unless fields like that are added in the future).

However, we can't tell the difference between fields like IPAddress vs IpAddress - both would be converted to ip_address. Examples: InterconnectAttachment has cloudRouterIpAddress, but RegionBackendService has fastIPMove.

[roaks3]

However, we can't tell the difference between fields like IPAddress vs IpAddress - both would be converted to ip_address. Examples: InterconnectAttachment has cloudRouterIpAddress, but RegionBackendService has fastIPMove.

Ah right, the acronym handling makes it lossy. Thanks for explaining!