Skip to content

Fix partial match regexes#14866

Merged
NickElliot merged 4 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0from
NickElliot:regex7.0.0fix
Aug 15, 2025
Merged

Fix partial match regexes#14866
NickElliot merged 4 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0from
NickElliot:regex7.0.0fix

Conversation

@NickElliot

Copy link
Copy Markdown
Contributor

redo #14610 and #14811

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

provider: fixed many import functions throughout the provider that erroneously matched a subset of the provided input, leading to unclear error messages when using `terraform input` with invalid resource IDs

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 25 files changed, 70 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 25 files changed, 70 insertions(+), 65 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1974
Passed tests: 1718
Skipped tests: 255
Affected tests: 1

Click here to see the affected service packages
  • bigquery
  • compute
  • datacatalog
  • osconfig
  • resourcemanager
  • apigee
  • bigtable
  • cloudfunctions
  • dns
  • sql
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmv1 unit test and tgc test failures appear to be unrelated to this change.

@NickElliot NickElliot added this pull request to the merge queue Aug 15, 2025
Merged via the queue into GoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0 with commit ffc76c4 Aug 15, 2025
22 of 26 checks passed
@NickElliot NickElliot deleted the regex7.0.0fix branch August 15, 2025 17:12
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Sep 26, 2025
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants