Standardized required_with behavior for write-only fields

[melinath]

Clean-up / standardization for write-only fields that requires some small breaking changes. #14933 (comment) for context.

I've gone through and tested the plan errors locally to compare the latest release with these changes.

Note: I believe the bigquerydatatransfer Config change is not breaking, because we already enforce it via a customize diff func. I'm not removing that in this PR to keep things simple.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: on `google_sql_user`, made `password_wo_version` required when `password_wo` is set

secretmanager: on `google_secret_manager_secret_version`, made `secret_data_wo` and `secret_data_wo_version` both required when one is set

monitoring: on `google_monitoring_uptime_check_config`, made it required to set exactly one of `http_check.auth_info.password` and `http_check.auth_info.password_wo`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 34 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 6 files changed, 34 insertions(+), 12 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field http_check.auth_info.password_wo within resource google_monitoring_uptime_check_config was added to exactly one of - reference
• Field http_check.auth_info.password within resource google_monitoring_uptime_check_config was added to exactly one of - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key_wo = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 222
Passed tests: 196
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages

• monitoring
• secretmanager
• sql
• bigquerydatatransfer

🟢 All tests passed!

View the build log

[melinath]

TGC failures are unrelated - this PR doesn't modify TGC. Breaking change failure is expected.

[BBBmau]

LGTM!

[NickElliot]

LGTM