Skip to content

Conversation

@c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 22, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


duaaeissa and others added 30 commits August 19, 2025 17:44
Co-authored-by: Shrishty Chandra <shrishty@google.com>
…omFlatten (GoogleCloudPlatform#14788)

Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
# Conflicts:
#	mmv1/products/bigquerydatatransfer/Config.yaml
#	mmv1/products/memorystore/Instance.yaml
#	mmv1/products/monitoring/UptimeCheckConfig.yaml
#	mmv1/products/redis/Cluster.yaml
#	mmv1/products/secretmanager/SecretVersion.yaml
#	mmv1/products/securesourcemanager/Instance.yaml
@google-cla
Copy link

google-cla bot commented Aug 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 310 files changed, 5367 insertions(+), 1863 deletions(-))
google-beta provider: Diff ( 328 files changed, 5568 insertions(+), 2008 deletions(-))
terraform-google-conversion: Diff ( 337 files changed, 5706 insertions(+), 1134 deletions(-))
Open in Cloud Shell: Diff ( 16 files changed, 449 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key_wo = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_iap_web_region_forwarding_rule_service_iam_binding, google_iap_web_region_forwarding_rule_service_iam_member, google_iap_web_region_forwarding_rule_service_iam_policy. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataSourceArtifactRegistryNpmPackage_basic
  • TestAccIapWebRegionForwardingRuleServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccIapWebRegionForwardingRuleServiceIamMemberGenerated_withAndWithoutCondition

Tests analytics

Total tests: 5490
Passed tests: 4860
Skipped tests: 594
Affected tests: 36

Click here to see the affected service packages

All service packages are affected

Action taken

Found 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLegacyNodeConfigAndBootDiskUpdate
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfig
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeType
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeTypeLegacy
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataFusionInstance_dataFusionInstanceCmekExample
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLegacyNodeConfigAndBootDiskUpdate [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfig [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeType [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeTypeLegacy [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@c2thorn
Copy link
Member Author

c2thorn commented Aug 22, 2025

TestAccContainerNodePool_withTaintsUpdate is newly failing, will have to fix on main

@c2thorn c2thorn requested a review from NickElliot August 22, 2025 19:01
@c2thorn c2thorn added this pull request to the merge queue Aug 22, 2025
Merged via the queue into GoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0 with commit 73a1e53 Aug 22, 2025
26 of 29 checks passed
@c2thorn c2thorn deleted the 7.0.0-sync branch August 22, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.