Add new resource RegionHealthSource to terraform-beta

[jkrish-c]

provider.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_compute_region_health_sources` (beta)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 415 insertions(+))
google-beta provider: Diff ( 13 files changed, 2522 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 251 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_health_aggregation_policy (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_health_aggregation_policy" "primary" {
  policy_type = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_compute_region_health_aggregation_policy
• google_compute_region_health_source

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_compute_region_health_aggregation_policy, google_compute_region_health_source. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1268
Passed tests: 1182
Skipped tests: 83
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionHealthAggregationPolicy_update
• TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample
• TestAccComputeRegionHealthSource_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionHealthAggregationPolicy_update [Error message] [Debug log]
TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample [Error message] [Debug log]
TestAccComputeRegionHealthSource_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1302
Passed tests: 1216
Skipped tests: 83
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample
• TestAccComputeRegionHealthSource_update

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 1302
Passed tests: 1215
Skipped tests: 83
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
• TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample
• TestAccComputeRegionHealthSource_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample [Debug log]
TestAccComputeRegionHealthSource_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]
TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample [Debug log]
TestAccComputeRegionHealthSource_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1302
Passed tests: 1215
Skipped tests: 83
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
• TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample
• TestAccComputeRegionHealthSource_update

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 1302
Passed tests: 1216
Skipped tests: 83
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample
• TestAccComputeRegionHealthSource_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample [Debug log]
TestAccComputeRegionHealthSource_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]
TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample [Debug log]
TestAccComputeRegionHealthSource_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1303
Passed tests: 1218
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1304
Passed tests: 1219
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 7 files changed, 1386 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1316
Passed tests: 1231
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[jkrish-c]

Marking it ready for review even though the check is failing. https://screenshot.googleplex.com/AGWmpZbEpy9ajcf

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

This looks straightforward; just a few minor cleanups/fixes.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 210 insertions(+))
google-beta provider: Diff ( 7 files changed, 1379 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 183 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1316
Passed tests: 1231
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

TGC test failure is unrelated.