Skip to content

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 8, 2025

Guess the cai identity from create_url and self_link automatically if we can.

cai_identity in only needed if we cannot guess the cai identity.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 21 files changed, 21 insertions(+), 21 deletions(-))

@zli82016 zli82016 force-pushed the tgc-id branch 2 times, most recently from 31f20c8 to 5fa86a9 Compare September 8, 2025 23:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 21 files changed, 21 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 21 files changed, 21 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 21 files changed, 21 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 21 files changed, 21 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 21 files changed, 21 insertions(+), 21 deletions(-))

@zli82016 zli82016 requested a review from trodge September 12, 2025 17:11
@zli82016
Copy link
Member Author

zli82016 commented Sep 12, 2025

The 21 resources that have diffs are in old package and not supported in TGC. They are not in the ResourceConverters

@zli82016 zli82016 marked this pull request as ready for review September 12, 2025 17:13
@trodge
Copy link
Contributor

trodge commented Sep 15, 2025

The 21 resources that have diffs are in old package and not supported in TGC. They are not in the ResourceConverters

Does anyone know why they have files in the repo if they're not supported?

@zli82016
Copy link
Member Author

The 21 resources that have diffs are in old package and not supported in TGC. They are not in the ResourceConverters

Does anyone know why they have files in the repo if they're not supported?

In the legacy TGC, the resources are generated to TGC by default. Only by adding exclude_tgc: true manually, the resource will not be generated to TGC.

@zli82016 zli82016 added this pull request to the merge queue Sep 15, 2025
Merged via the queue into GoogleCloudPlatform:main with commit d8b6962 Sep 15, 2025
27 checks passed
@zli82016 zli82016 deleted the tgc-id branch September 15, 2025 19:01
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Sep 17, 2025
sahil-mahajan-google pushed a commit to sahil-mahajan-google/magic-modules that referenced this pull request Sep 19, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Sep 26, 2025
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants