-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adds RolloutKind provider for SaasRuntime #15124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds RolloutKind provider for SaasRuntime #15124
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_saas_runtime_rollout_kind" "primary" {
annotations = # value needed
}
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_saas_runtime_rollout_kind" "primary" {
annotations = # value needed
}
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
| - name: updateUnitKindStrategy | ||
| type: Enum | ||
| description: |- | ||
| The config for updating the unit kind. By default, the unit kind will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"By default..."
What does the API return when nothing (null) is sent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API will not return any value either, but when parsed it will be the default value, which is "UPDATE_UNIT_KIND_STRATEGY_UNSPECIFIED".
What the description is saying is that the behavior of unspecified/unset is the same as "UPDATE_UNIT_KIND_STRATEGY_ON_START".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks- so the effective return is null.
mmv1/templates/terraform/examples/saas_runtime_rollout_kind_basic.tf.tmpl
Outdated
Show resolved
Hide resolved
… updateUnitKindStrategy
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
rileykarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
86f5dfe
Uh oh!
There was an error while loading. Please reload this page.