Skip to content

Conversation

@g-dreva
Copy link
Contributor

@g-dreva g-dreva commented Sep 11, 2025

`google_saas_runtime_rollout_kind`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 251 insertions(+))
google-beta provider: Diff ( 7 files changed, 1581 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 175 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_saas_runtime_rollout_kind (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_saas_runtime_rollout_kind" "primary" {
  annotations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • saasruntime

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample
  • TestAccSaasRuntimeRolloutKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample [Debug log]
TestAccSaasRuntimeRolloutKind_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 251 insertions(+))
google-beta provider: Diff ( 7 files changed, 1581 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 175 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_saas_runtime_rollout_kind (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_saas_runtime_rollout_kind" "primary" {
  annotations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • saasruntime

🟢 All tests passed!

View the build log

@g-dreva g-dreva marked this pull request as ready for review September 11, 2025 21:49
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 251 insertions(+))
google-beta provider: Diff ( 7 files changed, 1584 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 175 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • saasruntime

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeRolloutKind_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSaasRuntimeRolloutKind_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

- name: updateUnitKindStrategy
type: Enum
description: |-
The config for updating the unit kind. By default, the unit kind will be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"By default..."

What does the API return when nothing (null) is sent?

Copy link
Contributor Author

@g-dreva g-dreva Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API will not return any value either, but when parsed it will be the default value, which is "UPDATE_UNIT_KIND_STRATEGY_UNSPECIFIED".

What the description is saying is that the behavior of unspecified/unset is the same as "UPDATE_UNIT_KIND_STRATEGY_ON_START".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks- so the effective return is null.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 245 insertions(+))
google-beta provider: Diff ( 7 files changed, 1562 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 175 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 245 insertions(+))
google-beta provider: Diff ( 7 files changed, 1562 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 175 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • saasruntime

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • saasruntime

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rileykarson rileykarson added this pull request to the merge queue Sep 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 86f5dfe Sep 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants