Skip to content

Conversation

@q2w
Copy link
Contributor

@q2w q2w commented Sep 12, 2025

@q2w q2w force-pushed the abhiwa-cloudrunv2 branch 2 times, most recently from 09a85b4 to 73cd4e8 Compare September 13, 2025 05:34
@q2w q2w force-pushed the abhiwa-cloudrunv2 branch from 73cd4e8 to e8199d0 Compare September 15, 2025 15:49
@q2w q2w marked this pull request as ready for review September 15, 2025 16:27
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@rileykarson
Copy link
Member

@modular-magician reassign-reviewer zli82016

@github-actions github-actions bot requested review from zli82016 and removed request for rileykarson September 16, 2025 16:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 108 insertions(+))

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 changed the title Add support for cloud_run_v2_service TGC Add support for google_cloud_run_v2_service to TGC Sep 17, 2025
@zli82016 zli82016 changed the title Add support for google_cloud_run_v2_service to TGC Add support for google_cloud_run_v2_service to TGC Sep 17, 2025
@zli82016 zli82016 added this pull request to the merge queue Sep 17, 2025
Merged via the queue into GoogleCloudPlatform:main with commit ac9adbe Sep 17, 2025
27 checks passed
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Sep 17, 2025
sahil-mahajan-google pushed a commit to sahil-mahajan-google/magic-modules that referenced this pull request Sep 19, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Sep 26, 2025
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants