Skip to content

Conversation

@skysarthak
Copy link
Contributor

@skysarthak skysarthak commented Sep 18, 2025

Fixes hashicorp/terraform-provider-google#22427

Issue summary: Terraform website docs and CloudSQL doc for data_cache_config are not up to date. This is leading to confusion where users incorrectly expect data_cache_config to default to false for all ENTERPRISE_PLUS edition instances.

Mitigation: CloudSQL doc is now fixed to reflect the most up to date behavior. This PR aims to fix the Terraform website doc.

b/387580491

I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@SirGitsalot SirGitsalot added this pull request to the merge queue Sep 19, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 23852fb Sep 19, 2025
24 of 25 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Sep 26, 2025
Co-authored-by: Sarthak Tandon <sarthaktn@google.com>
@skysarthak skysarthak deleted the local branch October 14, 2025 06:31
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
Co-authored-by: Sarthak Tandon <sarthaktn@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 20, 2025
Co-authored-by: Sarthak Tandon <sarthaktn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

misleading documentation of google_sql_database_instance data_cache_config behavior in Enterprise Plus Edition

3 participants