Support the new Broker type of mirroring endpoint group.

[duvni]

Mirroring endpoint group resource now supports DIRECT and BROKER types.
The default type (and existing type) is DIRECT, and this PR allows users of the beta provider to create resources with the new BROKER type.

networksecurity: added `type` and `mirroring_deployment_groups` fields to `google_network_security_mirroring_endpoint_group` resource (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 64 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 178 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field type added as optional with a default value and force new on pre-existing resource google_network_security_mirroring_endpoint_group. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 68
Passed tests: 57
Skipped tests: 4
Affected tests: 7

Click here to see the affected service packages

• networksecurity

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample
• TestAccNetworkSecurityMirroringEndpointGroupAssociation_update
• TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample
• TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBrokerBasicExample
• TestAccNetworkSecurityMirroringEndpointGroup_update
• TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupMirroringExample
• TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileMirroringExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityMirroringEndpointGroupAssociation_networkSecurityMirroringEndpointGroupAssociationBasicExample [Debug log]
TestAccNetworkSecurityMirroringEndpointGroupAssociation_update [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBasicExample [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_networkSecurityMirroringEndpointGroupBrokerBasicExample [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_update [Debug log]
TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupMirroringExample [Debug log]
TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileMirroringExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[duvni]

@zli82016, following on the terraform-provider-breaking-change-test check that failed.
It is failing on the new type field that was added with a default value. I can confirm that at the API-level, the default matches the schema default which is DIRECT. This is true for all existing resources and is documented appropriately, so this change is safe and override-breaking-change label can be added.

See: https://googlecloudplatform.github.io/magic-modules/breaking-changes/breaking-changes#no-new-optional-default

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 64 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 178 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field type added as optional with a default value and force new on pre-existing resource google_network_security_mirroring_endpoint_group. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 68
Passed tests: 64
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages

• networksecurity

🟢 All tests passed!

View the build log