Skip to content

Conversation

@shuyama1
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 12 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 12 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1293
Passed tests: 1203
Skipped tests: 84
Affected tests: 6

Click here to see the affected service packages
  • compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample
  • TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update
  • TestAccComputeProjectDefaultNetworkTier_basic
  • TestAccComputeProjectDefaultNetworkTier_modify
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccDataSourceGoogleStoragePoolTypes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeProjectDefaultNetworkTier_basic [Error message] [Debug log]
TestAccComputeProjectDefaultNetworkTier_modify [Error message] [Debug log]
TestAccDataSourceGoogleStoragePoolTypes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 15 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 15 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1293
Passed tests: 1207
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeProjectDefaultNetworkTier_modify
  • TestAccDataSourceGoogleStoragePoolTypes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeProjectDefaultNetworkTier_modify [Error message] [Debug log]
TestAccDataSourceGoogleStoragePoolTypes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 15 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 15 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1293
Passed tests: 1206
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeProjectDefaultNetworkTier_basic
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccDataSourceGoogleStoragePoolTypes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeProjectDefaultNetworkTier_basic [Error message] [Debug log]
TestAccDataSourceGoogleStoragePoolTypes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@shuyama1
Copy link
Member Author

test passed in the replaying is expected, but just run test on TC, just in case

@shuyama1 shuyama1 requested a review from zli82016 September 29, 2025 18:58
@shuyama1 shuyama1 added this pull request to the merge queue Sep 29, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 4013ab5 Sep 29, 2025
24 of 25 checks passed
@shuyama1 shuyama1 deleted the TestAccComputeProjectDefaultNetworkTier_modify branch September 29, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants