Add actions.save_findings.output_config.storage_path field to google_data_loss_prevention_job_trigger.

[patrickmoy]

Enables support for saving findings to Cloud Storage.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dlp: added `actions.save_findings.output_config.storage_path` field to `google_data_loss_prevention_job_trigger` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 64
Passed tests: 63
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataLossPreventionJobTrigger_dlpJobTriggerSaveToCloudStorage

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataLossPreventionJobTrigger_dlpJobTriggerSaveToCloudStorage [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 64
Passed tests: 64
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datalossprevention

🟢 All tests passed!

View the build log

[patrickmoy]

Of note: the tests I added pass, but we are getting a failure on downstream unit tests that look unrelated. https://screenshot.googleplex.com/3PVL2Ppum2bCudJ

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 64
Passed tests: 64
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datalossprevention

🟢 All tests passed!

View the build log

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 214 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

[modular-magician]

Tests analytics

Total tests: 64
Passed tests: 64
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datalossprevention

🟢 All tests passed!

View the build log

[zli82016]

Of note: the tests I added pass, but we are getting a failure on downstream unit tests that look unrelated. https://screenshot.googleplex.com/3PVL2Ppum2bCudJ

Feel free to ignore the TGC unit tests failure.

[NickElliot]

LGTM!