Skip to content

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Oct 3, 2025

settings.0.version is computed and is possible to change by API.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 129
Passed tests: 102
Skipped tests: 26
Affected tests: 1

Click here to see the affected service packages
  • sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member Author

zli82016 commented Oct 3, 2025

TestAccDataSourceSqlDatabaseInstances_tierFilter passed in CI.

The failed test is unrelated.

@zli82016 zli82016 marked this pull request as ready for review October 3, 2025 19:47
@zli82016 zli82016 requested a review from hao-nan-li October 3, 2025 19:47
@zli82016 zli82016 added this pull request to the merge queue Oct 3, 2025
Merged via the queue into GoogleCloudPlatform:main with commit f692d66 Oct 3, 2025
27 of 28 checks passed
@zli82016 zli82016 deleted the sql-test branch October 3, 2025 20:23
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
g-dreva pushed a commit to g-dreva/magic-modules that referenced this pull request Oct 15, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants