[BLOCK] Add storage pool type field

[sahil-mahajan-google]

netapp: added additional field `type` in `google_netapp_storage_pool` resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 88 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 33
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 123 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 123 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 32
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappStoragePool_unifiedStoragePoolCreate

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_unifiedStoragePoolCreate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 125 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 125 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 32
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappStoragePool_unifiedStoragePoolCreate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_unifiedStoragePoolCreate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 121 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 121 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 33
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.