Netapp all squash

[Mehul3217]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

netapp: Modified `squashMode` param for netapp_volumes resources. Added custom logic to handle the API behaviour

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 142 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 142 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_NetappVolumeBasicExample_update
• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_NetappVolumeBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[trodge]

@modular-magician reassign-reviewer @trodge

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 150 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 150 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode default value changed from <nil> to SQUASH_MODE_UNSPECIFIED on google_netapp_volume - reference
• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 140 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 140 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode default value changed from <nil> to SQUASH_MODE_UNSPECIFIED on google_netapp_volume - reference
• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 140 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 140 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode default value changed from <nil> to SQUASH_MODE_UNSPECIFIED on google_netapp_volume - reference
• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 139 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 139 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode default value changed from <nil> to SQUASH_MODE_UNSPECIFIED on google_netapp_volume - reference
• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_NetappVolumeBasicExample_update
• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_NetappVolumeBasicExample_update [Error message] [Debug log]
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_NetappVolumeBasicExample_update
• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_NetappVolumeBasicExample_update
• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_NetappVolumeBasicExample_update [Error message] [Debug log]
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_NetappVolumeBasicExample_update [Error message] [Debug log]
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 32
Passed tests: 30
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_NetappVolumeBasicExample_update
• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_NetappVolumeBasicExample_update [Error message] [Debug log]
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 149 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 2 files changed, 149 insertions(+), 12 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode default value changed from <nil> to SQUASH_MODE_UNSPECIFIED on google_netapp_volume - reference
• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_NetappVolumeBasicExample_update
• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_NetappVolumeBasicExample_update [Error message] [Debug log]
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[Mehul3217]

The test is now failing with:

---[ REQUEST ]---------------------------------------
GET /v1beta1/projects/ci-test-project-188019/locations/northamerica-northeast1/operations/operation-1761986488836-6428472c4207d-99188080-6f3e1482?alt=json HTTP/1.1
Host: netapp.googleapis.com
User-Agent: Terraform/1.11.0 (+https://www.terraform.io) Terraform-Plugin-SDK/2.37.0 terraform-provider-google-beta/acc
Content-Type: application/json
Accept-Encoding: gzip


-----------------------------------------------------
2025/11/01 08:51:27 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Content-Type: application/json; charset=UTF-8
Date: Sat, 01 Nov 2025 08:51:27 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/ci-test-project-188019/locations/northamerica-northeast1/operations/operation-1761986488836-6428472c4207d-99188080-6f3e1482",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.netapp.v1beta1.OperationMetadata",
    "createTime": "2025-11-01T08:41:28.973261133Z",
    "endTime": "2025-11-01T08:51:22.659713512Z",
    "target": "projects/ci-test-project-188019/locations/northamerica-northeast1/volumes/tf-test-test-volumerjlk1mqjbs",
    "verb": "create",
    "requestedCancellation": false,
    "apiVersion": "v1beta1"
  },
  "done": true,
  "error": {
    "code": 13,
    "message": "an internal error has occurred"
  }
}

Yes this looks to be the API error outside the scope of this PR

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 936 insertions(+), 524 deletions(-))
google-beta provider: Diff ( 3 files changed, 840 insertions(+), 874 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

[modular-magician]

Tests analytics

Total tests: 36
Passed tests: 35
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/netapp coverage: 64.9% of statements

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 936 insertions(+), 524 deletions(-))
google-beta provider: Diff ( 3 files changed, 840 insertions(+), 874 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

[modular-magician]

Tests analytics

Total tests: 36
Passed tests: 35
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/netapp coverage: 64.9% of statements

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 935 insertions(+), 524 deletions(-))
google-beta provider: Diff ( 3 files changed, 839 insertions(+), 874 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 36
Passed tests: 35
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/netapp coverage: 64.9% of statements

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 935 insertions(+), 524 deletions(-))
google-beta provider: Diff ( 3 files changed, 841 insertions(+), 876 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field export_policy.rules.squash_mode transitioned from optional+computed to optional google_netapp_volume - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 36
Passed tests: 35
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

[trodge]

What is the reason for reintroducing the breaking change?

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/netapp coverage: 65.1% of statements

[Mehul3217]

What is the reason for reintroducing the breaking change?

It is needed because when user defines sqaushMode in inital config and then modifies the config to not include squashMode Terraform adds the previous value which causes the next apply to fail. We do not want the default value from API

And this feature is not live yet, it is behind mendel experiments so should be safe to merge

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.