-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add network_pass_through_lb_traffic_policy field to google_compute_region_backend_service resource to support zonal affinity for internal passthrough network load balancer.
#15698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1302 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
network_pass_through_lb_traffic_policy field to google_compute_region_backend_service resource to support zonal affinity.network_pass_through_lb_traffic_policy field to google_compute_region_backend_service resource to support zonal affinity for internal passthrough network load balancer.
|
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test failures unrelated
93c9a58
…_region_backend_service` resource to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#15698)
…_region_backend_service` resource to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#15698)
…_region_backend_service` resource to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#15698)
This change adds the
network_pass_through_lb_traffic_policyfield togoogle_compute_region_backend_serviceresource. This allows users to configure Zonal Affinity for Internal Passthrough Network Load Balancers.A new acceptance test,
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy, has been added to verify the functionality of this feature.