Skip to content

Conversation

@xingyazhao
Copy link
Contributor

This change adds the network_pass_through_lb_traffic_policy field to google_compute_region_backend_service resource. This allows users to configure Zonal Affinity for Internal Passthrough Network Load Balancers.

A new acceptance test, TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy, has been added to verify the functionality of this feature.

compute: added `network_pass_through_lb_traffic_policy` field to `google_compute_region_backend_service` resource.

@github-actions github-actions bot requested a review from NickElliot November 12, 2025 18:13
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 4 files changed, 295 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 65 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1302
Passed tests: 1217
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@xingyazhao xingyazhao changed the title Add network_pass_through_lb_traffic_policy field to google_compute_region_backend_service resource to support zonal affinity. Add network_pass_through_lb_traffic_policy field to google_compute_region_backend_service resource to support zonal affinity for internal passthrough network load balancer. Nov 12, 2025
@github-actions
Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures unrelated

@NickElliot NickElliot added this pull request to the merge queue Nov 18, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 93c9a58 Nov 18, 2025
29 of 31 checks passed
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025
…_region_backend_service` resource to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#15698)
deliaqi pushed a commit to deliaqi/magic-modules that referenced this pull request Nov 26, 2025
…_region_backend_service` resource to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#15698)
vkanishk15 pushed a commit to vkanishk15/magic-modules that referenced this pull request Dec 11, 2025
…_region_backend_service` resource to support zonal affinity for internal passthrough network load balancer. (GoogleCloudPlatform#15698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants