Skip to content

Conversation

@BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Nov 13, 2025

Looks like when transferring certain fields within the netapp service we forgot to remove the provider=google-beta from this specific test.

PR just removes this from configurations since we have no beta only fields within the service itself

Fixes hashicorp/terraform-provider-google#24741

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@BBBmau
Copy link
Collaborator Author

BBBmau commented Nov 13, 2025

@modular-magician reassign-reviewer

@BBBmau BBBmau requested a review from slevenick November 13, 2025 18:37
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 15 deletions(-))
google-beta provider: Diff ( 1 file changed, 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 35
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappVolume_volumeExportPolicyWithSquashMode

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_volumeExportPolicyWithSquashMode [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 16 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 16 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 36
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp

🟢 All tests passed!

View the build log

@BBBmau BBBmau added this pull request to the merge queue Nov 14, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 1378637 Nov 14, 2025
24 checks passed
@BBBmau BBBmau deleted the fix-networkservices-voluemexport-test branch November 14, 2025 23:15
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025
deliaqi pushed a commit to deliaqi/magic-modules that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccNetappVolume_volumeExportPolicyWithSquashMode

3 participants