Skip to content

Conversation

@BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Nov 24, 2025

Reverts #15783

This didn't fully solve the problem and we'll need to test this thoroughly on a separate TeamCity Project in order for the sweepers to continue working like before despite the build log error

We get a new build log error with this PR that was introduced, there's some progress but it's best that we refrain from continuing work on this on magic-modules repo itself

TeamCity -Service Sweeper Build Logs after PR


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 57 deletions(-))
google-beta provider: Diff ( 1 file changed, 43 insertions(+), 18 deletions(-))

@BBBmau BBBmau requested a review from ScottSuarez November 24, 2025 17:47
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5814
Passed tests: 5176
Skipped tests: 616
Affected tests: 22

Click here to see the affected service packages

All service packages are affected

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
  • TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy
  • TestAccContainerCluster_networkPerformanceConfig
  • TestAccContainerCluster_withTPUConfig
  • TestAccContainerCluster_withTpu
  • TestAccContainerNodePool_secondaryBootDisks
  • TestAccDataFusionInstance_dataFusionInstanceCmekExample
  • TestAccDialogflowCXFlow_dialogflowcxFlowFullExample
  • TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
  • TestAccDialogflowCXTestCase_update
  • TestAccDialogflowCXTool_dialogflowcxToolDataStoreExample
  • TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccNetworkServicesGateway_swpUpdate
  • TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample
  • TestAccNetworkServicesServiceBinding_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log]
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXTool_dialogflowcxToolDataStoreExample [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccNetworkServicesGateway_swpUpdate [Error message] [Debug log]
TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample [Error message] [Debug log]
TestAccNetworkServicesServiceBinding_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau BBBmau added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 8028aaf Nov 25, 2025
25 of 27 checks passed
@BBBmau BBBmau deleted the revert-15783-use-teamcity-go-test-for-sweepers branch November 25, 2025 17:52
deliaqi pushed a commit to deliaqi/magic-modules that referenced this pull request Nov 26, 2025
vkanishk15 pushed a commit to vkanishk15/magic-modules that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants