-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Revert "teamcity/sweepers: replace flags to envvars to use teamcity-go-test command"
#15802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mcity-go…" This reverts commit d72cb5c.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5814 Click here to see the affected service packages
Action takenFound 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
…mcity-go-test` command" (GoogleCloudPlatform#15802)
…mcity-go-test` command" (GoogleCloudPlatform#15802)
Reverts #15783
This didn't fully solve the problem and we'll need to test this thoroughly on a separate TeamCity Project in order for the sweepers to continue working like before despite the build log error
We get a new build log error with this PR that was introduced, there's some progress but it's best that we refrain from continuing work on this on magic-modules repo itself
TeamCity -Service Sweeper Build Logs after PR