Skip to content

Conversation

@jgforsberg
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.
Part of hashicorp/terraform-provider-google#24791

`google_network_services_multicast_group_consumer_activation`

This YAML file defines the MulticastGroupConsumerActivation resource, including its properties, parameters, and async operations.
Added tests for updating network services multicast group consumer activation.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1639 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1639 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 204 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_multicast_group_consumer_activation (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_multicast_group_consumer_activation" "primary" {
  multicast_group = # value needed
  state {
    state = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 80
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample [Error message] [Debug log]
TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Added references for guides and API documentation to the Multicast Group Consumer Activation YAML file.
Removed 'multicastGroup' field from the YAML configuration.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1644 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1644 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_multicast_group_consumer_activation (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_multicast_group_consumer_activation" "primary" {
  multicast_group = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 80
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 80
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample [Debug log]
TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample [Debug log]
TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@jgforsberg jgforsberg marked this pull request as ready for review December 5, 2025 19:24
@github-actions github-actions bot requested a review from roaks3 December 5, 2025 19:25
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 82
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 82
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 82
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices

🟢 All tests passed!

View the build log

Removed the '[Output only]' prefix from the uniqueId description.
Removed '[Output only]' from description fields for clarity.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1610 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 194 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 157 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 82
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 82
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkservices

🟢 All tests passed!

View the build log

@github-actions
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants