Skip to content

Conversation

@mufaddalnaya
Copy link
Contributor

@mufaddalnaya mufaddalnaya commented Jan 20, 2026

Fixes hashicorp/terraform-provider-google#22221

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

oracledatabase: added `peerAutonomousDatabases`, `disasterRecoverySupportedLocations`, `sourceConfig` fields to Autonomous database resource.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 20, 2026
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@BBBmau
Copy link
Collaborator

BBBmau commented Jan 20, 2026

I'm going ahead and closing this PR as it's a duplicate of a previous PR:

@BBBmau BBBmau closed this Jan 20, 2026
@BBBmau BBBmau reopened this Jan 21, 2026
@BBBmau BBBmau removed the request for review from malhotrasagar2212 January 21, 2026 15:19
@modular-magician modular-magician added service/oracledatabase and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 21, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 264 insertions(+), 75 deletions(-))
google-beta provider: Diff ( 4 files changed, 264 insertions(+), 75 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 111 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseDisasterRecoveryExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseDisasterRecoveryExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My only concern was the change from required -> O + C but the API references it as optional since this does provide another way to provide the autonomous database

we also get fulling TC Passing tests from this build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support source-config-autonomous-database for cross region peer DB creation

3 participants