Enable write-only support for private_key from google_compute_(region_)ssl_certificate

[muresan]

Fixes: hashicorp/terraform-provider-google#24626

compute: Enable write-only support for `private_key` to `google_compute_ssl_certificate` resource

compute: Enable write-only support for `private_key` to `google_compute_region_ssl_certificate` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 134 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 8 files changed, 134 insertions(+), 32 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 62 insertions(+), 15 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_ssl_certificate (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

Resource: google_compute_ssl_certificate (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1330
Passed tests: 1244
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[muresan]

Hello @trodge could you take a look at this PR ?
Can you suggest where to add the tests mentioned above, I don't see any tests specific for google_compute_(region_)ssl_certificate, how would it work ?
I saw that resource_compute_region_target_https_proxy_test.go.tmpl uses google_compute_region_ssl_certificate should I add another certificate in that test that makes use of the _wo attributes ?
Thanks.

[trodge]

You can add the field to any of the tests in mmv1/templates/examples which are listed under examples in the resource yaml.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 262 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 8 files changed, 262 insertions(+), 32 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 65 insertions(+), 15 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 225 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_ssl_certificate (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

Resource: google_compute_ssl_certificate (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeRegionSslCertificate_regionSslCertificateBasicWriteonlyExample
• TestAccComputeSslCertificate_sslCertificateBasicWriteonlyExample

Tests analytics

Total tests: 1332
Passed tests: 1244
Skipped tests: 88
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[muresan]

Added the resources in examples. Can I have some guidance on the terraform-google-conversion test failure? Thanks

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

/gcbrun

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 262 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 8 files changed, 262 insertions(+), 32 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 65 insertions(+), 15 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 225 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_ssl_certificate (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

Resource: google_compute_ssl_certificate (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeRegionSslCertificate_regionSslCertificateBasicWriteonlyExample
• TestAccComputeSslCertificate_sslCertificateBasicWriteonlyExample

Tests analytics

Total tests: 1336
Passed tests: 1248
Skipped tests: 88
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 272 insertions(+), 40 deletions(-))
google-beta provider: Diff ( 10 files changed, 272 insertions(+), 40 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 225 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_ssl_certificate (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

Resource: google_compute_ssl_certificate (16 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccComputeRegionSslCertificate_regionSslCertificateBasicWriteonlyExample
• TestAccComputeSslCertificate_sslCertificateBasicWriteonlyExample

Tests analytics

Total tests: 1338
Passed tests: 1248
Skipped tests: 88
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionTargetHttpsProxy_update
• TestAccComputeTargetHttpsProxy_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeTargetHttpsProxy_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionTargetHttpsProxy_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test