Skip to content

Conversation

@habh-11
Copy link
Contributor

@habh-11 habh-11 commented Jan 26, 2026

Also fix the OpenAPI toolset tests where the service account comes from an environment variable instead of a hardcoded string.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

ces: added MCP Toolset to `toolset` resource

Also fix the OpenAPI toolset tests where the service account comes from an environment variable instead of a hardcoded string.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 26, 2026
@github-actions github-actions bot requested a review from melinath January 26, 2026 19:07
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/ces and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 26, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2278 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 5 files changed, 2278 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 379 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 574 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 40
Skipped tests: 0
Affected tests: 10

Click here to see the affected service packages
  • ces

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCESToolset_cesToolsetMcpApiKeyConfigExample
  • TestAccCESToolset_cesToolsetMcpApiKeyConfigExample_update
  • TestAccCESToolset_cesToolsetMcpBearerTokenConfigExample
  • TestAccCESToolset_cesToolsetMcpBearerTokenConfigExample_update
  • TestAccCESToolset_cesToolsetMcpOauthConfigExample
  • TestAccCESToolset_cesToolsetMcpOauthConfigExample_update
  • TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample
  • TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample_update
  • TestAccCESToolset_cesToolsetMcpServiceAgentIdTokenAuthConfigExample
  • TestAccCESToolset_cesToolsetMcpServiceAgentIdTokenExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCESToolset_cesToolsetMcpApiKeyConfigExample [Debug log]
TestAccCESToolset_cesToolsetMcpApiKeyConfigExample_update [Debug log]
TestAccCESToolset_cesToolsetMcpBearerTokenConfigExample [Debug log]
TestAccCESToolset_cesToolsetMcpBearerTokenConfigExample_update [Debug log]
TestAccCESToolset_cesToolsetMcpOauthConfigExample [Debug log]
TestAccCESToolset_cesToolsetMcpOauthConfigExample_update [Debug log]
TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample [Debug log]
TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample_update [Debug log]
TestAccCESToolset_cesToolsetMcpServiceAgentIdTokenAuthConfigExample [Debug log]
TestAccCESToolset_cesToolsetMcpServiceAgentIdTokenExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a straightforward set of field additions. Tests are passing & all fields are tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants