feat: added oauth settings

[google-pratyush]

Original PR: #15633

iap: added `client_id`, `client_secret`, and `client_secret_sha256` fields to `google_iap_settings` resource

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 96 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 5 files changed, 96 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))

[rileykarson]

This currently modifies every existing test- could you undo these modifications and add a dedicated test for it instead? Changes that modify every existing test are often not backwards compatible.

[modular-magician]

Tests analytics

Total tests: 103
Passed tests: 77
Skipped tests: 24
Affected tests: 2

Click here to see the affected service packages

• iap

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIapSettings_iapSettingsBasicExample
• TestAccIapSettings_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIapSettings_iapSettingsBasicExample [Debug log]
TestAccIapSettings_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[Deepraj1996]

This currently modifies every existing test- could you undo these modifications and add a dedicated test for it instead? Changes that modify every existing test are often not backwards compatible.

@rileykarson I have made the requested changes in PR (#15633), could you please review those and let me know if any changes needs to be done there?

[Deepraj1996]

@rileykarson could you please review the PR again, we have added the separate test for oauth fields and removed the modification from existing test.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 247 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 247 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 131 insertions(+))

[modular-magician]

Tests analytics

Total tests: 105
Passed tests: 77
Skipped tests: 24
Affected tests: 4

Click here to see the affected service packages

• iap

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIapSettings_iapSettingsBasicExample
• TestAccIapSettings_iapSettingsOauthStorageBasic
• TestAccIapSettings_iapSettingsOauthStorageExample
• TestAccIapSettings_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIapSettings_iapSettingsBasicExample [Debug log]
TestAccIapSettings_iapSettingsOauthStorageBasic [Debug log]
TestAccIapSettings_iapSettingsOauthStorageExample [Debug log]
TestAccIapSettings_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test