Skip to content

Comments

Changed intelligence config name field from url_param_only to ignore_read#16483

Merged
melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
melinath:yaqs-4010639086615265280
Feb 20, 2026
Merged

Changed intelligence config name field from url_param_only to ignore_read#16483
melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
melinath:yaqs-4010639086615265280

Conversation

@melinath
Copy link
Member

context: yaqs/4010639086615265280

The primary purpose of this change is to ensure the field is properly detected as having an API equivalent. The API returns a full path with a project number instead of project id, so there's no point in trying to have drift detection on this field - hence, ignore_read.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 33 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 33 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 0
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages
  • storagecontrol

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleStorageControlFolderIntelligenceConfig_basic
  • TestAccDataSourceGoogleStorageControlOrganizationIntelligenceConfig_basic
  • TestAccDataSourceGoogleStorageControlProjectIntelligenceConfig_basic
  • TestAccStorageControlFolderIntelligenceConfig_update
  • TestAccStorageControlOrganizationIntelligenceConfig_update
  • TestAccStorageControlProjectIntelligenceConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleStorageControlFolderIntelligenceConfig_basic [Debug log]
TestAccDataSourceGoogleStorageControlOrganizationIntelligenceConfig_basic [Debug log]
TestAccDataSourceGoogleStorageControlProjectIntelligenceConfig_basic [Debug log]
TestAccStorageControlFolderIntelligenceConfig_update [Debug log]
TestAccStorageControlOrganizationIntelligenceConfig_update [Debug log]
TestAccStorageControlProjectIntelligenceConfig_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@melinath
Copy link
Member Author

@modular-magician reassign-reviewer

@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li February 20, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants