colab: fix FullExample test - add expiration_time to importStateVerifyIgnore#16520
Merged
BBBmau merged 1 commit intoGoogleCloudPlatform:mainfrom Mar 17, 2026
Merged
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 19 Click here to see the affected service packages
🟢 All tests passed! View the build log |
bcreddy-gcp
approved these changes
Mar 11, 2026
bcreddy-gcp
approved these changes
Mar 12, 2026
Member
|
@BBBmau , the test passed in the previous three-nights. Is this fix still needed? |
Collaborator
Author
seems like it's unneccessary, we could include it to prevent flakey tests from occurring. I think that would be the best option to prevent false failures from occurring in nightlies |
Merged
via the queue into
GoogleCloudPlatform:main
with commit Mar 17, 2026
1ab1d93
22 checks passed
This was referenced Mar 17, 2026
aditikumarii-google
pushed a commit
to aditikumarii-google/magic-modules
that referenced
this pull request
Mar 18, 2026
ChuAmberZhang
pushed a commit
to ChuAmberZhang/magic-modules
that referenced
this pull request
Apr 29, 2026
gitika-yadav
pushed a commit
to gitika-yadav/magic-modules
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TeamCity Build History
TestFailure due to wanting to import a time based value
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.