Skip to content

Add primary_location field to biglake iceberg catalog#16557

Merged
slevenick merged 2 commits intoGoogleCloudPlatform:mainfrom
rambleraptor:biglake-catalog-primary-location
Mar 2, 2026
Merged

Add primary_location field to biglake iceberg catalog#16557
slevenick merged 2 commits intoGoogleCloudPlatform:mainfrom
rambleraptor:biglake-catalog-primary-location

Conversation

@rambleraptor
Copy link
Copy Markdown
Contributor

@rambleraptor rambleraptor commented Feb 26, 2026

Adds primary_location field to Biglake Iceberg Catalog

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

biglake: added `primary_location` to  `google_biglake_iceberg_catalog` resource

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 85 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 85 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 11
Passed tests: 0
Skipped tests: 0
Affected tests: 11

Click here to see the affected service packages
  • biglakeiceberg

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBiglakeIcebergIcebergCatalogIamBindingGenerated
  • TestAccBiglakeIcebergIcebergCatalogIamMemberGenerated
  • TestAccBiglakeIcebergIcebergCatalogIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergCatalog_biglakeIcebergCatalogExample
  • TestAccBiglakeIcebergIcebergCatalog_biglakeIcebergCatalogPrimaryLocationExample
  • TestAccBiglakeIcebergIcebergCatalog_biglakeIcebergCatalog_update
  • TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated
  • TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated
  • TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample
  • TestAccBiglakeIcebergIcebergNamespace_update

Get to know how VCR tests work

Comment thread mmv1/products/biglakeiceberg/IcebergCatalog.yaml Outdated
@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBiglakeIcebergIcebergCatalogIamBindingGenerated [Debug log]
TestAccBiglakeIcebergIcebergCatalogIamMemberGenerated [Debug log]
TestAccBiglakeIcebergIcebergCatalogIamPolicyGenerated [Debug log]
TestAccBiglakeIcebergIcebergCatalog_biglakeIcebergCatalogExample [Debug log]
TestAccBiglakeIcebergIcebergCatalog_biglakeIcebergCatalogPrimaryLocationExample [Debug log]
TestAccBiglakeIcebergIcebergCatalog_biglakeIcebergCatalog_update [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamBindingGenerated [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamMemberGenerated [Debug log]
TestAccBiglakeIcebergIcebergNamespaceIamPolicyGenerated [Debug log]
TestAccBiglakeIcebergIcebergNamespace_biglakeIcebergNamespaceExample [Debug log]
TestAccBiglakeIcebergIcebergNamespace_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rambleraptor rambleraptor requested a review from slevenick March 2, 2026 19:47
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 85 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 85 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • biglakeiceberg

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants