Skip to content

Upgrade go version 1.24 -> 1.25#16655

Closed
HappyMary16 wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
HappyMary16:update-go-version
Closed

Upgrade go version 1.24 -> 1.25#16655
HappyMary16 wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
HappyMary16:update-go-version

Conversation

@HappyMary16
Copy link
Copy Markdown
Member

@HappyMary16 HappyMary16 commented Mar 10, 2026

Go version upgrade is required in order to upgrade the version for google.golang.org/api from v0.267.0 -> v0.270.0.
New google.golang.org/api version contains a new API field required to implement hashicorp/terraform-provider-google#26395

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 10, 2026
@github-actions github-actions Bot requested a review from NickElliot March 10, 2026 14:30
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@aditikumarii-google
Copy link
Copy Markdown
Contributor

Hi,
Is there any specific date that is being tracked to merge it?
My changes for PR #16039 is pending on this change and we want to merge for the next rollout.
Is it possible to submit this PR?

@HappyMary16
Copy link
Copy Markdown
Member Author

Hi, Is there any specific date that is being tracked to merge it? My changes for PR #16039 is pending on this change and we want to merge for the next rollout. Is it possible to submit this PR?

Hi @aditikumarii-google, there are no specific date for it, but we also need it before next rollout. So it will be merged as soon as all check pass and review be done.

@github-actions
Copy link
Copy Markdown

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@HappyMary16
Copy link
Copy Markdown
Member Author

Hi @aditikumarii-google,
Updating go version requires more changes than one this PR, so terraform team started to work on it.

They already prepared PRs:
#16698
#16699

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@NickElliot NickElliot closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants