Skip to content

Add field loadBalancingScheme to resources compute_target_tcp_proxy (beta)#16681

Merged
BBBmau merged 10 commits intoGoogleCloudPlatform:mainfrom
rostislavbobo:targettcpproxy-lbscheme-global
Mar 20, 2026
Merged

Add field loadBalancingScheme to resources compute_target_tcp_proxy (beta)#16681
BBBmau merged 10 commits intoGoogleCloudPlatform:mainfrom
rostislavbobo:targettcpproxy-lbscheme-global

Conversation

@rostislavbobo
Copy link
Member

@rostislavbobo rostislavbobo commented Mar 11, 2026

Add the loadBalancingScheme field to Global Target TCP Proxy resource.

Fixes hashicorp/terraform-provider-google#26313

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `loadBalancingScheme` to resource `google_compute_target_tcp_proxy` (beta)
compute: make field `backendService` optional for resource `google_compute_target_tcp_proxy`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 34 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 96 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 17 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1383
Passed tests: 1292
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rostislavbobo rostislavbobo marked this pull request as ready for review March 11, 2026 12:31
@github-actions github-actions bot requested a review from BBBmau March 11, 2026 12:32
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions github-actions bot requested a review from BBBmau March 17, 2026 09:42
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 35 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 98 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 18 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1385
Passed tests: 1295
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 70 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 188 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 18 insertions(+), 6 deletions(-))

@rostislavbobo rostislavbobo force-pushed the targettcpproxy-lbscheme-global branch from 9198209 to 164aee5 Compare March 17, 2026 19:28
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 192 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 18 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1386
Passed tests: 1295
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeTargetTcpProxy_targetTcpProxyBasicBetaExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeTargetTcpProxy_targetTcpProxyBasicBetaExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1386
Passed tests: 1295
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeTargetTcpProxy_targetTcpProxyBasicBetaExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeTargetTcpProxy_targetTcpProxyBasicBetaExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rostislavbobo rostislavbobo force-pushed the targettcpproxy-lbscheme-global branch from 164aee5 to 252c5d2 Compare March 17, 2026 20:18
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 192 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 18 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1386
Passed tests: 1296
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@rostislavbobo
Copy link
Member Author

Hi @BBBmau , could you please take a look at the PR? It's in review for a while already and blocks my next #16747

@rostislavbobo rostislavbobo force-pushed the targettcpproxy-lbscheme-global branch from 252c5d2 to c886242 Compare March 19, 2026 22:05
@github-actions github-actions bot requested a review from BBBmau March 19, 2026 22:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 192 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 19 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 74 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 6 files changed, 194 insertions(+), 12 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 19 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1390
Passed tests: 1300
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1390
Passed tests: 1300
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform support for Load Balancing Scheme for global Target TCP Proxies (beta)

3 participants