Skip to content

remove the custom retention days field as the feature is not GA#16695

Merged
BBBmau merged 1 commit intoGoogleCloudPlatform:mainfrom
dubey-vivek:dubeyvivek/csql-cod
Mar 16, 2026
Merged

remove the custom retention days field as the feature is not GA#16695
BBBmau merged 1 commit intoGoogleCloudPlatform:mainfrom
dubey-vivek:dubeyvivek/csql-cod

Conversation

@dubey-vivek
Copy link
Copy Markdown
Contributor

@dubey-vivek dubey-vivek commented Mar 12, 2026

cloudsql: remove `max_custom_on_demand_retention_days` field from `sqladmin` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 12, 2026
@github-actions github-actions Bot requested a review from BBBmau March 12, 2026 10:06
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 16, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 35
Passed tests: 22
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages
  • backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanForCsqlResourceExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanForCsqlResourceExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@BBBmau BBBmau added this pull request to the merge queue Mar 16, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 9010866 Mar 16, 2026
29 checks passed
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 18, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants