Skip to content

Fixed Invalid value for field rateLimitOptions when updating SecurityPolicy rules#16731

Open
matheusaleixo-cit wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
matheusaleixo-cit:fix-invalid-value-for-rate-limit-options-when-updating-compute-security-policy-rule
Open

Fixed Invalid value for field rateLimitOptions when updating SecurityPolicy rules#16731
matheusaleixo-cit wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
matheusaleixo-cit:fix-invalid-value-for-rate-limit-options-when-updating-compute-security-policy-rule

Conversation

@matheusaleixo-cit
Copy link
Contributor

Updates use of updateMask for rate_limit_options in google_compute_security_policy and google_compute_security_policy_rule resources.
Also adds tests to replicate the reported issue.

Fixes: #17275

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: updated request updateMask for `rate_limit_options` field  to `google_compute_security_policy` resource
compute: updated request updateMask for `rate_limit_options` field  to `google_compute_security_policy_rule` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 16, 2026
@matheusaleixo-cit matheusaleixo-cit marked this pull request as ready for review March 17, 2026 18:18
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 March 17, 2026 18:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 196 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 196 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1390
Passed tests: 1293
Skipped tests: 90
Affected tests: 7

Click here to see the affected service packages
  • compute

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeSecurityPolicyRule_EnforceOnKeyUpdates
  • TestAccComputeSecurityPolicyRule_ruleActionUpdate
  • TestAccComputeSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs
  • TestAccComputeSecurityPolicyRule_withRateLimitOptions
  • TestAccComputeSecurityPolicy_EnforceOnKeyUpdates
  • TestAccComputeSecurityPolicy_ruleActionUpdate
  • TestAccComputeSecurityPolicy_withRateLimitOption_withMultipleEnforceOnKeyConfigs

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeSecurityPolicyRule_EnforceOnKeyUpdates [Debug log]
TestAccComputeSecurityPolicyRule_ruleActionUpdate [Debug log]
TestAccComputeSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs [Debug log]
TestAccComputeSecurityPolicyRule_withRateLimitOptions [Debug log]
TestAccComputeSecurityPolicy_EnforceOnKeyUpdates [Debug log]
TestAccComputeSecurityPolicy_ruleActionUpdate [Debug log]
TestAccComputeSecurityPolicy_withRateLimitOption_withMultipleEnforceOnKeyConfigs [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants