feat: added `google_artifact_registry_rule` by ramonvermeulen · Pull Request #16769 · GoogleCloudPlatform/magic-modules

ramonvermeulen · 2026-03-19T16:59:17Z

Closes hashicorp/terraform-provider-google#26050

Tests

╰─❮ make testacc TEST=./google/services/artifactregistry TESTARGS='-run=TestAccArtifactRegistryRule_artifactRegistryRule'                                                                                                                                                    ─╯
sh -c "'/Users/ramon/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/artifactregistry -v -run=TestAccArtifactRegistryRule_artifactRegistryRule -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample (14.85s)
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleFullExample (14.87s)
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleFull_update (23.15s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/artifactregistry (cached)

`google_artifact_registry_rule`

github-actions · 2026-03-22T08:46:47Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-03-23T16:23:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1230 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1230 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 210 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_artifact_registry_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_artifact_registry_rule" "primary" {
  condition {
    location = # value needed
  }
}

modular-magician · 2026-03-23T16:27:11Z

Tests analytics

Total tests: 49
Passed tests: 39
Skipped tests: 7
Affected tests: 3

Click here to see the affected service packages

artifactregistry

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample

TestAccArtifactRegistryRule_artifactRegistryRuleFullExample

TestAccArtifactRegistryRule_artifactRegistryRuleFull_update

Get to know how VCR tests work

modular-magician · 2026-03-23T16:28:14Z

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample [Debug log]
TestAccArtifactRegistryRule_artifactRegistryRuleFullExample [Debug log]
TestAccArtifactRegistryRule_artifactRegistryRuleFull_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

github-actions · 2026-03-26T09:59:01Z

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-03-30T10:02:26Z

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

malhotrasagar2212

Hi @ramonvermeulen, Thanks for the PR. Please have a look at the Missing Test Report for the condition.location field.
#16769 (comment)

ramonvermeulen · 2026-04-08T18:36:46Z

@malhotrasagar2212

Thanks for reviewing! I just updated the test case and added the correct documentation url.

Tests locally:

TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/artifactregistry -v -run=TestAccArtifactRegistryRule_artifactRegistryRule -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample (21.29s)
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleFullExample (21.29s)
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleFull_update (37.03s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/artifactregistry 38.661s

modular-magician · 2026-04-09T16:12:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1384 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1384 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 210 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

modular-magician · 2026-04-09T16:15:57Z

Tests analytics

Total tests: 49
Passed tests: 37
Skipped tests: 7
Affected tests: 5

Click here to see the affected service packages

artifactregistry

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample

TestAccArtifactRegistryRule_artifactRegistryRuleFullExample

TestAccArtifactRegistryRule_artifactRegistryRuleFull_update

Get to know how VCR tests work

modular-magician · 2026-04-09T16:17:15Z

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample [Debug log]
TestAccArtifactRegistryRule_artifactRegistryRuleFullExample [Debug log]
TestAccArtifactRegistryRule_artifactRegistryRuleFull_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-04-13T10:14:25Z

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-04-15T10:04:08Z

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

malhotrasagar2212

@ramonvermeulen Please look into the failing tests. Thanks.

ramonvermeulen · 2026-04-16T18:25:35Z

@ramonvermeulen Please look into the failing tests. Thanks.

I don't have access to the logs, also wondering how this test is affected by my changes. Can try to run the same test locally to see if it fails as well, or if it is only in VCR.

ramonvermeulen · 2026-04-17T07:31:46Z

@malhotrasagar2212 Only rebased, test runs fine locally:

╰─❯ make testacc TEST=./google/services/artifactregistry TESTARGS='-run=TestAccArtifactRegistryRule_'                                                                                                   ─╯
sh -c "'/Users/ramon/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/artifactregistry -v -run=TestAccArtifactRegistryRule_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
=== RUN   TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== PAUSE TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleFull_update
=== CONT  TestAccArtifactRegistryRule_artifactRegistryRuleFullExample
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleFullExample (18.20s)
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleBasicExample (27.73s)
--- PASS: TestAccArtifactRegistryRule_artifactRegistryRuleFull_update (32.91s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/artifactregistry 33.813s

╰─❯ make testacc TEST=./google/services/artifactregistry TESTARGS='-run=TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample'                                                     ─╯
sh -c "'/Users/ramon/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/artifactregistry -v -run=TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
=== PAUSE TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
=== CONT  TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
--- PASS: TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample (13.05s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/artifactregistry 13.931s

modular-magician · 2026-04-21T00:59:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1432 insertions(+))
google-beta provider: Diff ( 5 files changed, 1432 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 210 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

modular-magician · 2026-04-21T01:03:23Z

Tests analytics

Total tests: 50
Passed tests: 43
Skipped tests: 7
Affected tests: 0

Click here to see the affected service packages

artifactregistry

🟢 All tests passed!

View the build log

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 19, 2026

ramonvermeulen changed the title ~~feat: add boilerplate for google_artifact_registry_rule~~ feat: added google_artifact_registry_rule Mar 22, 2026

ramonvermeulen marked this pull request as ready for review March 22, 2026 08:46

github-actions bot requested a review from malhotrasagar2212 March 22, 2026 08:46

modular-magician added service/artifactregistry and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 23, 2026

modular-magician requested a review from annakuo March 23, 2026 16:23

malhotrasagar2212 reviewed Apr 2, 2026

View reviewed changes

Comment thread mmv1/products/artifactregistry/Rule.yaml Outdated

ramonvermeulen force-pushed the f/26050-artifact-registry-rules branch from 95ab709 to 41fcac5 Compare April 8, 2026 18:24

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 8, 2026

github-actions bot requested a review from malhotrasagar2212 April 8, 2026 18:25

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026

malhotrasagar2212 reviewed Apr 16, 2026

View reviewed changes

github-actions bot requested a review from malhotrasagar2212 April 16, 2026 18:26

ramonvermeulen added 3 commits April 17, 2026 09:21

feat: add boilerplate for google_artifact_registry_rule

f5d7db2

feat: final changes to resource

27625fd

test: add update test

d6f37f2

ramonvermeulen added 2 commits April 17, 2026 09:21

docs: update documentation url

f1e18c6

test: update test case to include location

8a02def

ramonvermeulen force-pushed the f/26050-artifact-registry-rules branch from 20d5d4a to 8a02def Compare April 17, 2026 07:21

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 17, 2026

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 21, 2026

Conversation

ramonvermeulen commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

modular-magician commented Mar 23, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Mar 23, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

malhotrasagar2212 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ramonvermeulen commented Apr 8, 2026

Uh oh!

modular-magician commented Apr 9, 2026

Diff report

Uh oh!

modular-magician commented Apr 9, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

malhotrasagar2212 left a comment

Choose a reason for hiding this comment

Uh oh!

ramonvermeulen commented Apr 16, 2026

Uh oh!

ramonvermeulen commented Apr 17, 2026

Uh oh!

modular-magician commented Apr 21, 2026

Diff report

Uh oh!

modular-magician commented Apr 21, 2026

Tests analytics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ramonvermeulen commented Mar 19, 2026 •

edited

Loading