Add image_spec support to google_vertex_ai_reasoning_engine by rileykarson · Pull Request #16935 · GoogleCloudPlatform/magic-modules

rileykarson · 2026-04-03T22:46:54Z

Nested makefiles regenerates the .tar.gz files so that we capture sources; could probably be made into Bazel rules into the future.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertexai: added `spec.source_code_spec.image_spec` support to `google_vertex_ai_reasoning_engine`

modular-magician · 2026-04-03T22:57:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 243 insertions(+))
google-beta provider: Diff ( 12 files changed, 317 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2026-04-03T23:06:57Z

Tests analytics

Total tests: 90
Passed tests: 82
Skipped tests: 3
Affected tests: 5

Click here to see the affected service packages

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-03T23:15:56Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineDeveloperConnectSourceExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineImageSpecExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceBasedDeploymentExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineImageSpecUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-03T23:21:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 317 insertions(+))
google-beta provider: Diff ( 12 files changed, 317 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2026-04-03T23:31:34Z

Tests analytics

Total tests: 90
Passed tests: 86
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-03T23:42:58Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineImageSpecUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-04-04T01:07:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 317 insertions(+))
google-beta provider: Diff ( 12 files changed, 317 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2026-04-04T01:16:57Z

Tests analytics

Total tests: 90
Passed tests: 87
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

rileykarson · 2026-04-06T16:10:54Z

+            allow_empty_object: true
+            send_empty_value: true


This combination seemed to send the right things- we send explicit null when not defined, and explicit empty when defined.

c2thorn · 2026-04-06T20:46:44Z

+              - name: 'buildArgs'
+                type: KeyValuePairs
+                send_empty_value: true
+                required: true


seems kind of like a weird combination: required, but allowed to be empty. I'd think that it will maybe be empty quite often, when users don't want any additional build arguments (not sure on this, but could be a common case?)
Would it be crazy to allow omitting this and treat it as empty?

Or maybe too much fiddlyness for its worth

Tested locally and it works- I think I just didn't reverify it with the final settings for the parent.

modular-magician · 2026-04-06T21:24:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 323 insertions(+))
google-beta provider: Diff ( 12 files changed, 323 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2026-04-06T21:34:43Z

Tests analytics

Total tests: 90
Passed tests: 84
Skipped tests: 3
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-06T21:39:53Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineDeveloperConnectSourceExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineImageSpecExample [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceBasedDeploymentExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Co-authored-by: Riley Karson <rileykarson@google.com>

modular-magician · 2026-04-06T22:02:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 324 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 12 files changed, 323 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2026-04-06T22:04:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 323 insertions(+))
google-beta provider: Diff ( 12 files changed, 323 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 45 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2026-04-06T22:12:33Z

Tests analytics

Total tests: 94
Passed tests: 90
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-06T22:14:17Z

Tests analytics

Total tests: 94
Passed tests: 90
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-06T22:16:07Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceVertexAIReasoningEngineQuery_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-04-06T22:18:15Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceVertexAIReasoningEngineQuery_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician added the service/aiplatform-agent-engine label Apr 3, 2026

rileykarson commented Apr 3, 2026

View reviewed changes

Comment thread mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_reasoning_engine_test.go.tmpl Outdated

Comment thread mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_reasoning_engine_test.go

rileykarson commented Apr 4, 2026

View reviewed changes

Comment thread mmv1/products/vertexai/ReasoningEngine.yaml Outdated

rileykarson requested a review from c2thorn April 6, 2026 16:09

rileykarson commented Apr 6, 2026

View reviewed changes

c2thorn approved these changes Apr 6, 2026

View reviewed changes

rileykarson added this pull request to the merge queue Apr 6, 2026

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 6, 2026

rileykarson added 4 commits April 6, 2026 14:50

Add image_spec support to google_vertex_ai_reasoning_engine

b1dd106

Apply suggestions from code review

768a612

Co-authored-by: Riley Karson <rileykarson@google.com>

Apply suggestion from @rileykarson

47e849c

fix build-args

67dedab

rileykarson force-pushed the vertex-dockerfile branch from 911068e to 67dedab Compare April 6, 2026 21:50

bad diff

cdeab35

rileykarson added this pull request to the merge queue Apr 6, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 64790af Apr 6, 2026
23 checks passed

rileykarson deleted the vertex-dockerfile branch April 6, 2026 22:32

Conversation

rileykarson commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Apr 3, 2026

Diff report

Uh oh!

modular-magician commented Apr 3, 2026

Tests analytics

Action taken

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Apr 3, 2026

Uh oh!

modular-magician commented Apr 3, 2026

Diff report

Uh oh!

modular-magician commented Apr 3, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 3, 2026

Uh oh!

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Tests analytics

Uh oh!

rileykarson Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

c2thorn Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

c2thorn Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

rileykarson Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Apr 6, 2026

Diff report

Uh oh!

modular-magician commented Apr 6, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 6, 2026

Uh oh!

modular-magician commented Apr 6, 2026

Diff report

Uh oh!

modular-magician commented Apr 6, 2026

Diff report

Uh oh!

modular-magician commented Apr 6, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 6, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 6, 2026

Uh oh!

modular-magician commented Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rileykarson commented Apr 3, 2026 •

edited

Loading