Add post-quantum key exchange to compute ssl policy resources

[jcqli]

b/458421784 Adds post-quantum key exchange to ssl policies api

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `post_quantum_key_exchange` field to `google_compute_ssl_policy` and `google_compute_region_ssl_policy` resources

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 87 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 121 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

• google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

[modular-magician]

Tests analytics

Total tests: 1408
Passed tests: 1313
Skipped tests: 90
Affected tests: 5

Click here to see the affected service packages

• compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionSslPolicy_postQuantumKeyExchange
• TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_sslPolicyBasicExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample [Error message] [Debug log]
TestAccComputeSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeSslPolicy_sslPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 87 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 121 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

• google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

[modular-magician]

Tests analytics

Total tests: 1408
Passed tests: 1314
Skipped tests: 90
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionSslPolicy_postQuantumKeyExchange
• TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_sslPolicyBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample [Error message] [Debug log]
TestAccComputeSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeSslPolicy_sslPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d2ec7be:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	10 files changed, 458 insertions(+), 4 deletions(-)
google-beta provider	View Diff	10 files changed, 458 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 87 insertions(+)
Open in Cloud Shell	View Diff	5 files changed, 121 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

• google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1426	1331	91	4

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionSslPolicy_postQuantumKeyExchange
• TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_sslPolicyBasicExample

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccComputeRegionSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
❌ Error · Log	-	TestAccComputeSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeSslPolicy_sslPolicyBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for d2ec7be!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7c0ac09:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	10 files changed, 466 insertions(+), 4 deletions(-)
google-beta provider	View Diff	10 files changed, 466 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 87 insertions(+)
Open in Cloud Shell	View Diff	5 files changed, 121 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

• google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1426	1331	91	4

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionSslPolicy_postQuantumKeyExchange
• TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_sslPolicyBasicExample

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccComputeRegionSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
❌ Error · Log	-	TestAccComputeSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeSslPolicy_sslPolicyBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for 7c0ac09!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 76496b1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	10 files changed, 468 insertions(+), 4 deletions(-)
google-beta provider	View Diff	10 files changed, 468 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 87 insertions(+)
Open in Cloud Shell	View Diff	5 files changed, 121 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

• google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

• compute

Please fix the compilation errors to complete your PR.

View the build log

@jcqli, @zli82016 VCR tests complete for 76496b1!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e01b769:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 542 insertions(+), 5 deletions(-)
google-beta provider	View Diff	12 files changed, 542 insertions(+), 5 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 87 insertions(+)
Open in Cloud Shell	View Diff	5 files changed, 121 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1448	1349	93	6

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeRegionSslPolicy_postQuantumKeyExchange
• TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_sslPolicyBasicExample
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeSslPolicy_postQuantumKeyExchange
✅ Log	✅	TestAccComputeSslPolicy_sslPolicyBasicExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeRegionSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for e01b769!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 90c19bc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 541 insertions(+), 4 deletions(-)
google-beta provider	View Diff	12 files changed, 541 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 87 insertions(+)
Open in Cloud Shell	View Diff	5 files changed, 121 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1448	1348	93	7

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeRegionSslPolicy_postQuantumKeyExchange
• TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_sslPolicyBasicExample
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
✅ Log	✅	TestAccComputeSslPolicy_postQuantumKeyExchange
✅ Log	✅	TestAccComputeSslPolicy_sslPolicyBasicExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeRegionSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for 90c19bc!

[jcqli]

Some of the test failures don't seem related to my changes, but the region ssl policy test passes locally for me screen/BfLLYX3Pfq8rvxs. I'm not sure why it fails in the PR

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c080911:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 511 insertions(+), 4 deletions(-)
google-beta provider	View Diff	12 files changed, 511 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 87 insertions(+)
Open in Cloud Shell	View Diff	4 files changed, 106 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1450	1355	93	2

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeRegionSslPolicy_postQuantumKeyExchange

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRegionSslPolicy_postQuantumKeyExchange
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for c080911!

[jcqli]

Thank you!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8f3a19c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 630 insertions(+), 1 deletion(-)
google-beta provider	View Diff	12 files changed, 630 insertions(+), 1 deletion(-)
terraform-google-conversion	View Diff	10 files changed, 93 insertions(+)
Open in Cloud Shell	View Diff	12 files changed, 321 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

• compute

Please fix the compilation errors to complete your PR.

View the build log

@jcqli, @zli82016 VCR tests complete for 8f3a19c!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0544df4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 627 insertions(+)
google-beta provider	View Diff	12 files changed, 627 insertions(+)
terraform-google-conversion	View Diff	10 files changed, 93 insertions(+)
Open in Cloud Shell	View Diff	12 files changed, 321 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1452	1357	93	2

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeRegionSslPolicy_regionSslPolicyPostQuantumExample
• TestAccComputeSslPolicy_sslPolicyPostQuantumExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeSslPolicy_sslPolicyPostQuantumExample
❌ Error · Log	-	TestAccComputeRegionSslPolicy_regionSslPolicyPostQuantumExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for 0544df4!

[zli82016]

=== CONT TestAccComputeRegionSslPolicy_regionSslPolicyPostQuantumExample
resource_compute_region_ssl_policy_generated_test.go:109: Step 1/3 error: Error running apply: exit status 1

    Error: Error creating RegionSslPolicy: googleapi: Error 400: Invalid value for field 'resource.name': 'tf_test_post_quantum_region_ssl_policy4fa1jigl81'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'
    Details:
    [
      {
        "@type": "type.googleapis.com/google.rpc.ErrorInfo",
        "domain": "compute.googleapis.com",
        "metadata": {
          "field": "resource.name",
          "reason": "Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'",
          "value": "tf_test_post_quantum_region_ssl_policy4fa1jigl81"
        },
        "reason": "INVALID_FIELD_VALUE"
      },
      {
        "@type": "type.googleapis.com/google.rpc.LocalizedMessage",
        "locale": "en-US",
        "message": "Invalid value for field 'resource.name': 'tf_test_post_quantum_region_ssl_policy4fa1jigl81'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'"
      }
    ]
    , invalid
    
      with google_compute_region_ssl_policy.post-quantum-region-ssl-policy,
      on terraform_plugin_test.tf line 12, in resource "google_compute_region_ssl_policy" "post-quantum-region-ssl-policy":
      12: resource "google_compute_region_ssl_policy" "post-quantum-region-ssl-policy" {

[jcqli]

=== CONT TestAccComputeRegionSslPolicy_regionSslPolicyPostQuantumExample resource_compute_region_ssl_policy_generated_test.go:109: Step 1/3 error: Error running apply: exit status 1

    Error: Error creating RegionSslPolicy: googleapi: Error 400: Invalid value for field 'resource.name': 'tf_test_post_quantum_region_ssl_policy4fa1jigl81'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'

Oops, fixed the name. Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 276c8a3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 627 insertions(+)
google-beta provider	View Diff	12 files changed, 627 insertions(+)
terraform-google-conversion	View Diff	10 files changed, 93 insertions(+)
Open in Cloud Shell	View Diff	12 files changed, 321 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1452	1358	93	1

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeRegionSslPolicy_regionSslPolicyPostQuantumExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRegionSslPolicy_regionSslPolicyPostQuantumExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@jcqli VCR tests complete for 276c8a3!

[jcqli]

Thank you!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a67173c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	12 files changed, 634 insertions(+), 7 deletions(-)
google-beta provider	View Diff	12 files changed, 634 insertions(+), 7 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 93 insertions(+)
Open in Cloud Shell	View Diff	12 files changed, 321 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1452	1351	93	8

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeRegionSslPolicy_regionInherit
• TestAccComputeRegionSslPolicy_update
• TestAccComputeRegionSslPolicy_update_from_custom
• TestAccComputeRegionSslPolicy_update_to_custom
• TestAccComputeSslPolicy_postQuantumKeyExchange
• TestAccComputeSslPolicy_update
• TestAccComputeSslPolicy_update_from_custom
• TestAccComputeSslPolicy_update_to_custom

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRegionSslPolicy_regionInherit
✅ Log	✅	TestAccComputeRegionSslPolicy_update
✅ Log	✅	TestAccComputeRegionSslPolicy_update_from_custom
✅ Log	✅	TestAccComputeRegionSslPolicy_update_to_custom
✅ Log	✅	TestAccComputeSslPolicy_postQuantumKeyExchange
✅ Log	✅	TestAccComputeSslPolicy_update
✅ Log	✅	TestAccComputeSslPolicy_update_from_custom
✅ Log	✅	TestAccComputeSslPolicy_update_to_custom

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@jcqli, @zli82016 VCR tests complete for a67173c!

[zli82016]

LGTM. Thanks for working on this.