Skip to content

Fix oracledatabase adb basic and full tests#17119

Merged
c2thorn merged 7 commits into
GoogleCloudPlatform:mainfrom
apoorvanadella:main
Apr 15, 2026
Merged

Fix oracledatabase adb basic and full tests#17119
c2thorn merged 7 commits into
GoogleCloudPlatform:mainfrom
apoorvanadella:main

Conversation

@apoorvanadella
Copy link
Copy Markdown
Contributor

@apoorvanadella apoorvanadella commented Apr 15, 2026

Removed check for 'cidr' attribute in the test case because it is not a required field

TestAccOracleDatabaseAutonomousDatabases_basic

Fixes hashicorp/terraform-provider-google#26676
Removed check for 'cidr' attribute in autonomous databases test.

fixes hashicorp/terraform-provider-google/issues/26676
@github-actions github-actions Bot requested a review from c2thorn April 15, 2026 00:37
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 27
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@apoorvanadella apoorvanadella changed the title Fix oracledatabase adb basic test Fix oracledatabase adb basic and full tests Apr 15, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 6 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 27
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants