Skip to content

Add Vector Search collection CMEK support#17129

Merged
zli82016 merged 7 commits intoGoogleCloudPlatform:mainfrom
kkanska:add-vector-search-collection-cmek-support
Apr 16, 2026
Merged

Add Vector Search collection CMEK support#17129
zli82016 merged 7 commits intoGoogleCloudPlatform:mainfrom
kkanska:add-vector-search-collection-cmek-support

Conversation

@kkanska
Copy link
Copy Markdown
Contributor

@kkanska kkanska commented Apr 15, 2026

This PR introduces support for CMEK in Vector Search Collection feature.

vectorsearch: added `encryption_spec` field to `google_vector_search_collection` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@kkanska
Copy link
Copy Markdown
Contributor Author

kkanska commented Apr 15, 2026

Local test run is passing

$ make testacc TEST=./google/services/vectorsearch TESTARGS='-run=TestAccVectorSearchCollection'
sh -c "'/usr/local/google/home/kkanska/dev/go/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/vectorsearch -v -run=TestAccVectorSearchCollection -timeout 240m -ldflags="-X=[github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc](http://github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc)"
=== RUN   TestAccVectorSearchCollection_vectorsearchCollectionBasicExample
=== PAUSE TestAccVectorSearchCollection_vectorsearchCollectionBasicExample
=== RUN   TestAccVectorSearchCollection_vectorsearchCollectionCmekExample
=== PAUSE TestAccVectorSearchCollection_vectorsearchCollectionCmekExample
=== RUN   TestAccVectorSearchCollection_update
=== PAUSE TestAccVectorSearchCollection_update
=== CONT  TestAccVectorSearchCollection_vectorsearchCollectionBasicExample
=== CONT  TestAccVectorSearchCollection_update
=== CONT  TestAccVectorSearchCollection_vectorsearchCollectionCmekExample
--- PASS: TestAccVectorSearchCollection_vectorsearchCollectionBasicExample (36.56s)
--- PASS: TestAccVectorSearchCollection_vectorsearchCollectionCmekExample (102.90s)
--- PASS: TestAccVectorSearchCollection_update (230.99s)
PASS
ok   [github.com/hashicorp/terraform-provider-google/google/services/vectorsearch](http://github.com/hashicorp/terraform-provider-google/google/services/vectorsearch) 231.142s

@kkanska
Copy link
Copy Markdown
Contributor Author

kkanska commented Apr 16, 2026

@malhotrasagar2212 I would kindly ask you for a fast review to make it before todays release cut. A critical customer is waiting for this feature.

@hao-nan-li hao-nan-li requested review from a team and shuyama1 and removed request for a team April 16, 2026 16:03
@malhotrasagar2212
Copy link
Copy Markdown
Collaborator

Looking into it.

@modular-magician modular-magician added service/vectorsearch and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 16, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 553 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 553 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 164 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • vectorsearch

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVectorSearchCollection_update
  • TestAccVectorSearchCollection_vectorsearchCollectionCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVectorSearchCollection_vectorsearchCollectionCmekExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccVectorSearchCollection_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@malhotrasagar2212
Copy link
Copy Markdown
Collaborator

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 16, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 553 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 5 files changed, 553 insertions(+), 53 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 164 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • vectorsearch

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVectorSearchCollection_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVectorSearchCollection_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@shuyama1 shuyama1 requested review from zli82016 and removed request for shuyama1 April 16, 2026 20:26
@zli82016
Copy link
Copy Markdown
Member

@kkanska , as the new field is immutable, we don't need to test its update. Can you revert the changes in mmv1/third_party/terraform/services/vectorsearch/resource_vector_search_collection_test.go? Thanks

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 16, 2026
@kkanska
Copy link
Copy Markdown
Contributor Author

kkanska commented Apr 16, 2026

@zli82016 done

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 16, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 265 insertions(+))
google-beta provider: Diff ( 4 files changed, 265 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 164 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • vectorsearch

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVectorSearchCollection_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVectorSearchCollection_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Copy Markdown
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants