Migrated compute metadata to use transport_tpg

[jcromanu]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_metadata` to remove a client library 

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 93 insertions(+), 160 deletions(-))
google-beta provider: Diff ( 8 files changed, 94 insertions(+), 160 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+), 268 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1417
Passed tests: 1311
Skipped tests: 91
Affected tests: 15

Click here to see the affected service packages

• compute

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample
• TestAccComputeFirewallPolicyRule_firewallPolicyRuleSecureTagsExample
• TestAccComputeFirewallPolicyRule_secureTags
• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update
• TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample
• TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update
• TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample
• TestAccComputeNetworkFirewallPolicyRule_secureTags
• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicyWithRules_update
• TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample
• TestAccComputeRegionNetworkFirewallPolicyRule_secureTags
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeRegionNetworkFirewallPolicyWithRules_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleSecureTagsExample [Error message] [Debug log]
TestAccComputeFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_networkFirewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_secureTags [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+), 57 deletions(-))
google-beta provider: Diff ( 4 files changed, 94 insertions(+), 91 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 83 insertions(+), 141 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1418
Passed tests: 1327
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[BBBmau]

LGTM!

I assume that once the migration is complete where transport_tpg is used across compute resources these methods will no longer be needed as a result of the migration?